[PATCH] xfs: Fix comments mentioning xfs_ialloc

[PATCH] xfs: Fix comments mentioning xfs_ialloc

[Yang Xu]

Since kernel commit 1abcf261016e ("xfs: move on-disk inode allocation out of xfs_ialloc()"),
xfs_ialloc has been renamed to xfs_init_new_inode. So update this in comments.

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
 fs/xfs/xfs_icache.c | 3 ++-
 fs/xfs/xfs_iops.c   | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index e1472004170e..39758015f302 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -770,7 +770,8 @@ xfs_iget(
 
 	/*
 	 * If we have a real type for an on-disk inode, we can setup the inode
-	 * now.	 If it's a new inode being created, xfs_ialloc will handle it.
+	 * now.	 If it's a new inode being created, xfs_init_new_inode will
+	 * handle it.
 	 */
 	if (xfs_iflags_test(ip, XFS_INEW) && VFS_I(ip)->i_mode != 0)
 		xfs_setup_existing_inode(ip);
diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
index a607d6aca5c4..f2ceb6c3fc50 100644
--- a/fs/xfs/xfs_iops.c
+++ b/fs/xfs/xfs_iops.c
@@ -1332,9 +1332,9 @@ xfs_diflags_to_iflags(
  * Initialize the Linux inode.
  *
  * When reading existing inodes from disk this is called directly from xfs_iget,
- * when creating a new inode it is called from xfs_ialloc after setting up the
- * inode. These callers have different criteria for clearing XFS_INEW, so leave
- * it up to the caller to deal with unlocking the inode appropriately.
+ * when creating a new inode it is called from xfs_init_new_inode after setting
+ * up the inode. These callers have different criteria for clearing XFS_INEW, so
+ * leave it up to the caller to deal with unlocking the inode appropriately.
  */
 void
 xfs_setup_inode(
-- 
2.23.0

Re: [PATCH] xfs: Fix comments mentioning xfs_ialloc

[Darrick J. Wong]

On Fri, Dec 17, 2021 at 10:01:59AM +0800, Yang Xu wrote:
> Since kernel commit 1abcf261016e ("xfs: move on-disk inode allocation out of xfs_ialloc()"),
> xfs_ialloc has been renamed to xfs_init_new_inode. So update this in comments.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>

Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/xfs_icache.c | 3 ++-
>  fs/xfs/xfs_iops.c   | 6 +++---
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index e1472004170e..39758015f302 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -770,7 +770,8 @@ xfs_iget(
>  
>  	/*
>  	 * If we have a real type for an on-disk inode, we can setup the inode
> -	 * now.	 If it's a new inode being created, xfs_ialloc will handle it.
> +	 * now.	 If it's a new inode being created, xfs_init_new_inode will
> +	 * handle it.
>  	 */
>  	if (xfs_iflags_test(ip, XFS_INEW) && VFS_I(ip)->i_mode != 0)
>  		xfs_setup_existing_inode(ip);
> diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c
> index a607d6aca5c4..f2ceb6c3fc50 100644
> --- a/fs/xfs/xfs_iops.c
> +++ b/fs/xfs/xfs_iops.c
> @@ -1332,9 +1332,9 @@ xfs_diflags_to_iflags(
>   * Initialize the Linux inode.
>   *
>   * When reading existing inodes from disk this is called directly from xfs_iget,
> - * when creating a new inode it is called from xfs_ialloc after setting up the
> - * inode. These callers have different criteria for clearing XFS_INEW, so leave
> - * it up to the caller to deal with unlocking the inode appropriately.
> + * when creating a new inode it is called from xfs_init_new_inode after setting
> + * up the inode. These callers have different criteria for clearing XFS_INEW, so
> + * leave it up to the caller to deal with unlocking the inode appropriately.
>   */
>  void
>  xfs_setup_inode(
> -- 
> 2.23.0
>