From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org, allison.henderson@oracle.com
Subject: Re: [PATCH 2/2] xfs: clean up the end of xfs_attri_item_recover
Date: Fri, 24 Jun 2022 09:13:18 +1000 [thread overview]
Message-ID: <20220623231318.GW227878@dread.disaster.area> (raw)
In-Reply-To: <165601680672.2928801.4056935562404690211.stgit@magnolia>
On Thu, Jun 23, 2022 at 01:40:06PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> The end of this function could use some cleanup -- the EAGAIN
> conditionals make it harder to figure out what's going on with the
> disposal of xattri_leaf_bp, and the dual error/ret variables aren't
> needed. Turn the EAGAIN case into a separate block documenting all the
> subtleties of recovering in the middle of an xattr update chain, which
> makes the rest of the prologue much simpler.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Decent cleanup. :)
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2022-06-23 23:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 20:39 [PATCHSET v2 0/2] xfs: random fixes for 5.19-rc4 Darrick J. Wong
2022-06-23 20:40 ` [PATCH 1/2] xfs: always free xattri_leaf_bp when cancelling a deferred op Darrick J. Wong
2022-06-23 23:09 ` Dave Chinner
2022-06-23 20:40 ` [PATCH 2/2] xfs: clean up the end of xfs_attri_item_recover Darrick J. Wong
2022-06-23 23:13 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220623231318.GW227878@dread.disaster.area \
--to=david@fromorbit.com \
--cc=allison.henderson@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox