From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: check inode core when scrubbing metadata files
Date: Tue, 15 Nov 2022 13:58:54 +1100 [thread overview]
Message-ID: <20221115025854.GV3600936@dread.disaster.area> (raw)
In-Reply-To: <166473482636.1084588.10974246607672500827.stgit@magnolia>
On Sun, Oct 02, 2022 at 11:20:26AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Metadata files (e.g. realtime bitmaps and quota files) do not show up in
> the bulkstat output, which means that scrub-by-handle does not work;
> they can only be checked through a specific scrub type. Therefore, each
> scrub type calls xchk_metadata_inode_forks to check the metadata for
> whatever's in the file.
>
> Unfortunately, that function doesn't actually check the inode record
> itself. Refactor the function a bit to make that happen.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
> fs/xfs/scrub/common.c | 40 ++++++++++++++++++++++++++++++++++------
> 1 file changed, 34 insertions(+), 6 deletions(-)
Looks reasonable. Will there be more metadata inode types to scrub
in future?
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-11-15 3:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 18:20 [PATCHSET v23.1 0/2] xfs: scrub inode core when checking metadata files Darrick J. Wong
2022-10-02 18:20 ` [PATCH 1/2] xfs: don't warn about files that are exactly s_maxbytes long Darrick J. Wong
2022-11-15 2:56 ` Dave Chinner
2022-10-02 18:20 ` [PATCH 2/2] xfs: check inode core when scrubbing metadata files Darrick J. Wong
2022-11-15 2:58 ` Dave Chinner [this message]
2022-11-15 3:31 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115025854.GV3600936@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox