Re: [PATCH 2/2] xfs: check inode core when scrubbing metadata files

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Nov 15, 2022 at 01:58:54PM +1100, Dave Chinner wrote:
> On Sun, Oct 02, 2022 at 11:20:26AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> > 
> > Metadata files (e.g. realtime bitmaps and quota files) do not show up in
> > the bulkstat output, which means that scrub-by-handle does not work;
> > they can only be checked through a specific scrub type.  Therefore, each
> > scrub type calls xchk_metadata_inode_forks to check the metadata for
> > whatever's in the file.
> > 
> > Unfortunately, that function doesn't actually check the inode record
> > itself.  Refactor the function a bit to make that happen.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> >  fs/xfs/scrub/common.c |   40 ++++++++++++++++++++++++++++++++++------
> >  1 file changed, 34 insertions(+), 6 deletions(-)
> 
> Looks reasonable. Will there be more metadata inode types to scrub
> in future?

For the realtime modernisation project, I am planning to shard the rt
volume into allocation groups and give each rtgroup its own rmap and
refcount btree.

> Reviewed-by: Dave Chinner <dchinner@redhat.com>

Thanks for the review!

--D

> 
> -- 
> Dave Chinner
> david@fromorbit.com