From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: dchinner@fromorbit.com, linux-xfs@vger.kernel.org
Subject: Re: [GIT PULL 14/22] xfs: fix bugs in parent pointer checking
Date: Wed, 12 Apr 2023 16:31:15 +1000 [thread overview]
Message-ID: <20230412063115.GJ3223426@dread.disaster.area> (raw)
In-Reply-To: <168127095051.417736.2174858080826643116.stg-ugh@frogsfrogsfrogs>
On Tue, Apr 11, 2023 at 08:48:26PM -0700, Darrick J. Wong wrote:
> Hi Dave,
>
> Please pull this branch with changes for xfs.
>
> As usual, I did a test-merge with the main upstream branch as of a few
> minutes ago, and didn't see any conflicts. Please let me know if you
> encounter any problems.
>
> --D
>
> The following changes since commit 0916056eba4fd816f8042a3960597c316ea10256:
>
> xfs: fix parent pointer scrub racing with subdirectory reparenting (2023-04-11 19:00:20 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/scrub-parent-fixes-6.4_2023-04-11
>
> for you to fetch changes up to 0916056eba4fd816f8042a3960597c316ea10256:
>
> xfs: fix parent pointer scrub racing with subdirectory reparenting (2023-04-11 19:00:20 -0700)
>
> ----------------------------------------------------------------
> xfs: fix bugs in parent pointer checking [v24.5]
>
> Jan Kara pointed out that the VFS doesn't take i_rwsem of a child
> subdirectory that is being moved from one parent to another. Upon
> deeper analysis, I realized that this was the source of a very hard to
> trigger false corruption report in the parent pointer checking code.
>
> Now that we've refactored how directory walks work in scrub, we can also
> get rid of all the unnecessary and broken locking to make parent pointer
> scrubbing work properly.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
>
> ----------------------------------------------------------------
Empty pull request?
Looks like the next pull-req is empty, too, and the commits that are
supposed to be in these are in pull-req after that?
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2023-04-12 6:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 3:48 [GIT PULL 14/22] xfs: fix bugs in parent pointer checking Darrick J. Wong
2023-04-12 6:31 ` Dave Chinner [this message]
2023-04-12 21:54 ` Darrick J. Wong
2023-04-13 0:50 ` [GIT PULL v2 " Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230412063115.GJ3223426@dread.disaster.area \
--to=david@fromorbit.com \
--cc=dchinner@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox