From: "Darrick J. Wong" <djwong@kernel.org>
To: david@fromorbit.com
Cc: dchinner@redhat.com, linux-xfs@vger.kernel.org
Subject: [GIT PULL v2 14/22] xfs: fix bugs in parent pointer checking
Date: Wed, 12 Apr 2023 17:50:34 -0700 [thread overview]
Message-ID: <20230413005034.GS360889@frogsfrogsfrogs> (raw)
In-Reply-To: <168127095051.417736.2174858080826643116.stg-ugh@frogsfrogsfrogs>
Hi Dave,
Please pull this branch with changes for xfs.
As usual, I did a test-merge with the main upstream branch as of a few
minutes ago, and didn't see any conflicts. Please let me know if you
encounter any problems.
--D
The following changes since commit 6bb9209ceebb07fd07cec25af04eed1809c654de:
xfs: always check the existence of a dirent's child inode (2023-04-11 19:00:18 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/scrub-parent-fixes-6.4_2023-04-12
for you to fetch changes up to 0916056eba4fd816f8042a3960597c316ea10256:
xfs: fix parent pointer scrub racing with subdirectory reparenting (2023-04-11 19:00:20 -0700)
----------------------------------------------------------------
xfs: fix bugs in parent pointer checking [v24.5]
Jan Kara pointed out that the VFS doesn't take i_rwsem of a child
subdirectory that is being moved from one parent to another. Upon
deeper analysis, I realized that this was the source of a very hard to
trigger false corruption report in the parent pointer checking code.
Now that we've refactored how directory walks work in scrub, we can also
get rid of all the unnecessary and broken locking to make parent pointer
scrubbing work properly.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
----------------------------------------------------------------
Darrick J. Wong (3):
xfs: remove xchk_parent_count_parent_dentries
xfs: simplify xchk_parent_validate
xfs: fix parent pointer scrub racing with subdirectory reparenting
fs/xfs/scrub/common.c | 22 -----
fs/xfs/scrub/common.h | 1 -
fs/xfs/scrub/parent.c | 226 +++++++++++++++++---------------------------------
3 files changed, 76 insertions(+), 173 deletions(-)
prev parent reply other threads:[~2023-04-13 0:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 3:48 [GIT PULL 14/22] xfs: fix bugs in parent pointer checking Darrick J. Wong
2023-04-12 6:31 ` Dave Chinner
2023-04-12 21:54 ` Darrick J. Wong
2023-04-13 0:50 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230413005034.GS360889@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox