From: Dave Chinner <david@fromorbit.com>
To: "renlei1@chinatelecom.cn" <renlei1@chinatelecom.cn>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] xfs: xfs_nfs_get_inode support zero generation
Date: Fri, 12 May 2023 16:02:04 +1000 [thread overview]
Message-ID: <20230512060204.GC3223426@dread.disaster.area> (raw)
In-Reply-To: <2023051210532845432129@chinatelecom.cn>
On Fri, May 12, 2023 at 10:53:29AM +0800, renlei1@chinatelecom.cn wrote:
> Yup, gen is 0 for the inodes created by libxfs, such as rootino, rbmino, rsumino.
> but those inodes will never be freed, and gen will always zero.
Yes, but why does that even matter for file handle verification?
> so I think bypass the verification if gen==0 is still valid.
Did you think about what happens when an inode->gen
overflows from 0xffffffff to 0 as part of a normal unlink/create
cycle?
-Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2023-05-12 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 10:17 [PATCH] xfs: xfs_nfs_get_inode support zero generation renlei1
2023-05-11 23:22 ` Darrick J. Wong
2023-05-12 2:00 ` Dave Chinner
[not found] ` <2023051210532845432129@chinatelecom.cn>
2023-05-12 3:31 ` Darrick J. Wong
2023-05-12 6:02 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512060204.GC3223426@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=renlei1@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox