* [xfs-linux:test-merge 13/13] fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 @ 2025-03-08 17:06 ` kernel test robot 2025-03-10 9:21 ` Carlos Maiolino 0 siblings, 1 reply; 4+ messages in thread From: kernel test robot @ 2025-03-08 17:06 UTC (permalink / raw) To: Carlos Maiolino; +Cc: llvm, oe-kbuild-all, linux-xfs tree: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git test-merge head: fac04210bb99888fd453db09239bed27436fd619 commit: fac04210bb99888fd453db09239bed27436fd619 [13/13] Merge branch 'xfs-6.15-atomicwrites' into for-next config: i386-buildonly-randconfig-003-20250308 (https://download.01.org/0day-ci/archive/20250309/202503090149.Wu0ag7zs-lkp@intel.com/config) compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250309/202503090149.Wu0ag7zs-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202503090149.Wu0ag7zs-lkp@intel.com/ All errors (new ones prefixed by >>): >> fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 746 | ret = xfs_file_write_checks(iocb, from, &iolock); | ~~~~~~~~~~~~~~~~~~~~~ ^ fs/xfs/xfs_file.c:434:1: note: 'xfs_file_write_checks' declared here 434 | xfs_file_write_checks( | ^ 435 | struct kiocb *iocb, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 436 | struct iov_iter *from, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 437 | unsigned int *iolock, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 438 | struct xfs_zone_alloc_ctx *ac) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. vim +746 fs/xfs/xfs_file.c 2e2383405824b9 Christoph Hellwig 2025-01-27 730 307185b178ac26 John Garry 2025-03-03 731 static noinline ssize_t 307185b178ac26 John Garry 2025-03-03 732 xfs_file_dio_write_atomic( 307185b178ac26 John Garry 2025-03-03 733 struct xfs_inode *ip, 307185b178ac26 John Garry 2025-03-03 734 struct kiocb *iocb, 307185b178ac26 John Garry 2025-03-03 735 struct iov_iter *from) 307185b178ac26 John Garry 2025-03-03 736 { 307185b178ac26 John Garry 2025-03-03 737 unsigned int iolock = XFS_IOLOCK_SHARED; 307185b178ac26 John Garry 2025-03-03 738 unsigned int dio_flags = 0; 307185b178ac26 John Garry 2025-03-03 739 ssize_t ret; 307185b178ac26 John Garry 2025-03-03 740 307185b178ac26 John Garry 2025-03-03 741 retry: 307185b178ac26 John Garry 2025-03-03 742 ret = xfs_ilock_iocb_for_write(iocb, &iolock); 307185b178ac26 John Garry 2025-03-03 743 if (ret) 307185b178ac26 John Garry 2025-03-03 744 return ret; 307185b178ac26 John Garry 2025-03-03 745 307185b178ac26 John Garry 2025-03-03 @746 ret = xfs_file_write_checks(iocb, from, &iolock); 307185b178ac26 John Garry 2025-03-03 747 if (ret) 307185b178ac26 John Garry 2025-03-03 748 goto out_unlock; 307185b178ac26 John Garry 2025-03-03 749 307185b178ac26 John Garry 2025-03-03 750 if (dio_flags & IOMAP_DIO_FORCE_WAIT) 307185b178ac26 John Garry 2025-03-03 751 inode_dio_wait(VFS_I(ip)); 307185b178ac26 John Garry 2025-03-03 752 307185b178ac26 John Garry 2025-03-03 753 trace_xfs_file_direct_write(iocb, from); 307185b178ac26 John Garry 2025-03-03 754 ret = iomap_dio_rw(iocb, from, &xfs_atomic_write_iomap_ops, 307185b178ac26 John Garry 2025-03-03 755 &xfs_dio_write_ops, dio_flags, NULL, 0); 307185b178ac26 John Garry 2025-03-03 756 307185b178ac26 John Garry 2025-03-03 757 if (ret == -EAGAIN && !(iocb->ki_flags & IOCB_NOWAIT) && 307185b178ac26 John Garry 2025-03-03 758 !(dio_flags & IOMAP_DIO_ATOMIC_SW)) { 307185b178ac26 John Garry 2025-03-03 759 xfs_iunlock(ip, iolock); 307185b178ac26 John Garry 2025-03-03 760 dio_flags = IOMAP_DIO_ATOMIC_SW | IOMAP_DIO_FORCE_WAIT; 307185b178ac26 John Garry 2025-03-03 761 iolock = XFS_IOLOCK_EXCL; 307185b178ac26 John Garry 2025-03-03 762 goto retry; 307185b178ac26 John Garry 2025-03-03 763 } 307185b178ac26 John Garry 2025-03-03 764 307185b178ac26 John Garry 2025-03-03 765 out_unlock: 307185b178ac26 John Garry 2025-03-03 766 if (iolock) 307185b178ac26 John Garry 2025-03-03 767 xfs_iunlock(ip, iolock); 307185b178ac26 John Garry 2025-03-03 768 return ret; 307185b178ac26 John Garry 2025-03-03 769 } 307185b178ac26 John Garry 2025-03-03 770 :::::: The code at line 746 was first introduced by commit :::::: 307185b178ac2695cbd964e9b0a5a9b7513bba93 xfs: Add xfs_file_dio_write_atomic() :::::: TO: John Garry <john.g.garry@oracle.com> :::::: CC: Carlos Maiolino <cem@kernel.org> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [xfs-linux:test-merge 13/13] fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 2025-03-08 17:06 ` [xfs-linux:test-merge 13/13] fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 kernel test robot @ 2025-03-10 9:21 ` Carlos Maiolino 2025-03-10 9:39 ` Philip Li 0 siblings, 1 reply; 4+ messages in thread From: Carlos Maiolino @ 2025-03-10 9:21 UTC (permalink / raw) To: kernel test robot; +Cc: llvm, oe-kbuild-all, linux-xfs On Sun, Mar 09, 2025 at 01:06:40AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git test-merge > head: fac04210bb99888fd453db09239bed27436fd619 > commit: fac04210bb99888fd453db09239bed27436fd619 [13/13] Merge branch 'xfs-6.15-atomicwrites' into for-next > config: i386-buildonly-randconfig-003-20250308 (https://download.01.org/0day-ci/archive/20250309/202503090149.Wu0ag7zs-lkp@intel.com/config) > compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250309/202503090149.Wu0ag7zs-lkp@intel.com/reproduce) Huh? All xfs branches are monitored? This was by no means to be tested. Carlos > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202503090149.Wu0ag7zs-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > >> fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 > 746 | ret = xfs_file_write_checks(iocb, from, &iolock); > | ~~~~~~~~~~~~~~~~~~~~~ ^ > fs/xfs/xfs_file.c:434:1: note: 'xfs_file_write_checks' declared here > 434 | xfs_file_write_checks( > | ^ > 435 | struct kiocb *iocb, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 436 | struct iov_iter *from, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 437 | unsigned int *iolock, > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 438 | struct xfs_zone_alloc_ctx *ac) > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. > > > vim +746 fs/xfs/xfs_file.c > > 2e2383405824b9 Christoph Hellwig 2025-01-27 730 > 307185b178ac26 John Garry 2025-03-03 731 static noinline ssize_t > 307185b178ac26 John Garry 2025-03-03 732 xfs_file_dio_write_atomic( > 307185b178ac26 John Garry 2025-03-03 733 struct xfs_inode *ip, > 307185b178ac26 John Garry 2025-03-03 734 struct kiocb *iocb, > 307185b178ac26 John Garry 2025-03-03 735 struct iov_iter *from) > 307185b178ac26 John Garry 2025-03-03 736 { > 307185b178ac26 John Garry 2025-03-03 737 unsigned int iolock = XFS_IOLOCK_SHARED; > 307185b178ac26 John Garry 2025-03-03 738 unsigned int dio_flags = 0; > 307185b178ac26 John Garry 2025-03-03 739 ssize_t ret; > 307185b178ac26 John Garry 2025-03-03 740 > 307185b178ac26 John Garry 2025-03-03 741 retry: > 307185b178ac26 John Garry 2025-03-03 742 ret = xfs_ilock_iocb_for_write(iocb, &iolock); > 307185b178ac26 John Garry 2025-03-03 743 if (ret) > 307185b178ac26 John Garry 2025-03-03 744 return ret; > 307185b178ac26 John Garry 2025-03-03 745 > 307185b178ac26 John Garry 2025-03-03 @746 ret = xfs_file_write_checks(iocb, from, &iolock); > 307185b178ac26 John Garry 2025-03-03 747 if (ret) > 307185b178ac26 John Garry 2025-03-03 748 goto out_unlock; > 307185b178ac26 John Garry 2025-03-03 749 > 307185b178ac26 John Garry 2025-03-03 750 if (dio_flags & IOMAP_DIO_FORCE_WAIT) > 307185b178ac26 John Garry 2025-03-03 751 inode_dio_wait(VFS_I(ip)); > 307185b178ac26 John Garry 2025-03-03 752 > 307185b178ac26 John Garry 2025-03-03 753 trace_xfs_file_direct_write(iocb, from); > 307185b178ac26 John Garry 2025-03-03 754 ret = iomap_dio_rw(iocb, from, &xfs_atomic_write_iomap_ops, > 307185b178ac26 John Garry 2025-03-03 755 &xfs_dio_write_ops, dio_flags, NULL, 0); > 307185b178ac26 John Garry 2025-03-03 756 > 307185b178ac26 John Garry 2025-03-03 757 if (ret == -EAGAIN && !(iocb->ki_flags & IOCB_NOWAIT) && > 307185b178ac26 John Garry 2025-03-03 758 !(dio_flags & IOMAP_DIO_ATOMIC_SW)) { > 307185b178ac26 John Garry 2025-03-03 759 xfs_iunlock(ip, iolock); > 307185b178ac26 John Garry 2025-03-03 760 dio_flags = IOMAP_DIO_ATOMIC_SW | IOMAP_DIO_FORCE_WAIT; > 307185b178ac26 John Garry 2025-03-03 761 iolock = XFS_IOLOCK_EXCL; > 307185b178ac26 John Garry 2025-03-03 762 goto retry; > 307185b178ac26 John Garry 2025-03-03 763 } > 307185b178ac26 John Garry 2025-03-03 764 > 307185b178ac26 John Garry 2025-03-03 765 out_unlock: > 307185b178ac26 John Garry 2025-03-03 766 if (iolock) > 307185b178ac26 John Garry 2025-03-03 767 xfs_iunlock(ip, iolock); > 307185b178ac26 John Garry 2025-03-03 768 return ret; > 307185b178ac26 John Garry 2025-03-03 769 } > 307185b178ac26 John Garry 2025-03-03 770 > > :::::: The code at line 746 was first introduced by commit > :::::: 307185b178ac2695cbd964e9b0a5a9b7513bba93 xfs: Add xfs_file_dio_write_atomic() > > :::::: TO: John Garry <john.g.garry@oracle.com> > :::::: CC: Carlos Maiolino <cem@kernel.org> > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [xfs-linux:test-merge 13/13] fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 2025-03-10 9:21 ` Carlos Maiolino @ 2025-03-10 9:39 ` Philip Li 2025-03-10 9:46 ` Carlos Maiolino 0 siblings, 1 reply; 4+ messages in thread From: Philip Li @ 2025-03-10 9:39 UTC (permalink / raw) To: Carlos Maiolino; +Cc: kernel test robot, llvm, oe-kbuild-all, linux-xfs On Mon, Mar 10, 2025 at 10:21:04AM +0100, Carlos Maiolino wrote: > On Sun, Mar 09, 2025 at 01:06:40AM +0800, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git test-merge > > head: fac04210bb99888fd453db09239bed27436fd619 > > commit: fac04210bb99888fd453db09239bed27436fd619 [13/13] Merge branch 'xfs-6.15-atomicwrites' into for-next > > config: i386-buildonly-randconfig-003-20250308 (https://download.01.org/0day-ci/archive/20250309/202503090149.Wu0ag7zs-lkp@intel.com/config) > > compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250309/202503090149.Wu0ag7zs-lkp@intel.com/reproduce) > > Huh? All xfs branches are monitored? This was by no means to be tested. thanks for the info, we will ignore this test-merge branch to avoid sending meaningless report. > > Carlos > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot <lkp@intel.com> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202503090149.Wu0ag7zs-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > >> fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 > > 746 | ret = xfs_file_write_checks(iocb, from, &iolock); > > | ~~~~~~~~~~~~~~~~~~~~~ ^ > > fs/xfs/xfs_file.c:434:1: note: 'xfs_file_write_checks' declared here > > 434 | xfs_file_write_checks( > > | ^ > > 435 | struct kiocb *iocb, > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 436 | struct iov_iter *from, > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 437 | unsigned int *iolock, > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 438 | struct xfs_zone_alloc_ctx *ac) > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > 1 error generated. > > > > > > vim +746 fs/xfs/xfs_file.c > > > > 2e2383405824b9 Christoph Hellwig 2025-01-27 730 > > 307185b178ac26 John Garry 2025-03-03 731 static noinline ssize_t > > 307185b178ac26 John Garry 2025-03-03 732 xfs_file_dio_write_atomic( > > 307185b178ac26 John Garry 2025-03-03 733 struct xfs_inode *ip, > > 307185b178ac26 John Garry 2025-03-03 734 struct kiocb *iocb, > > 307185b178ac26 John Garry 2025-03-03 735 struct iov_iter *from) > > 307185b178ac26 John Garry 2025-03-03 736 { > > 307185b178ac26 John Garry 2025-03-03 737 unsigned int iolock = XFS_IOLOCK_SHARED; > > 307185b178ac26 John Garry 2025-03-03 738 unsigned int dio_flags = 0; > > 307185b178ac26 John Garry 2025-03-03 739 ssize_t ret; > > 307185b178ac26 John Garry 2025-03-03 740 > > 307185b178ac26 John Garry 2025-03-03 741 retry: > > 307185b178ac26 John Garry 2025-03-03 742 ret = xfs_ilock_iocb_for_write(iocb, &iolock); > > 307185b178ac26 John Garry 2025-03-03 743 if (ret) > > 307185b178ac26 John Garry 2025-03-03 744 return ret; > > 307185b178ac26 John Garry 2025-03-03 745 > > 307185b178ac26 John Garry 2025-03-03 @746 ret = xfs_file_write_checks(iocb, from, &iolock); > > 307185b178ac26 John Garry 2025-03-03 747 if (ret) > > 307185b178ac26 John Garry 2025-03-03 748 goto out_unlock; > > 307185b178ac26 John Garry 2025-03-03 749 > > 307185b178ac26 John Garry 2025-03-03 750 if (dio_flags & IOMAP_DIO_FORCE_WAIT) > > 307185b178ac26 John Garry 2025-03-03 751 inode_dio_wait(VFS_I(ip)); > > 307185b178ac26 John Garry 2025-03-03 752 > > 307185b178ac26 John Garry 2025-03-03 753 trace_xfs_file_direct_write(iocb, from); > > 307185b178ac26 John Garry 2025-03-03 754 ret = iomap_dio_rw(iocb, from, &xfs_atomic_write_iomap_ops, > > 307185b178ac26 John Garry 2025-03-03 755 &xfs_dio_write_ops, dio_flags, NULL, 0); > > 307185b178ac26 John Garry 2025-03-03 756 > > 307185b178ac26 John Garry 2025-03-03 757 if (ret == -EAGAIN && !(iocb->ki_flags & IOCB_NOWAIT) && > > 307185b178ac26 John Garry 2025-03-03 758 !(dio_flags & IOMAP_DIO_ATOMIC_SW)) { > > 307185b178ac26 John Garry 2025-03-03 759 xfs_iunlock(ip, iolock); > > 307185b178ac26 John Garry 2025-03-03 760 dio_flags = IOMAP_DIO_ATOMIC_SW | IOMAP_DIO_FORCE_WAIT; > > 307185b178ac26 John Garry 2025-03-03 761 iolock = XFS_IOLOCK_EXCL; > > 307185b178ac26 John Garry 2025-03-03 762 goto retry; > > 307185b178ac26 John Garry 2025-03-03 763 } > > 307185b178ac26 John Garry 2025-03-03 764 > > 307185b178ac26 John Garry 2025-03-03 765 out_unlock: > > 307185b178ac26 John Garry 2025-03-03 766 if (iolock) > > 307185b178ac26 John Garry 2025-03-03 767 xfs_iunlock(ip, iolock); > > 307185b178ac26 John Garry 2025-03-03 768 return ret; > > 307185b178ac26 John Garry 2025-03-03 769 } > > 307185b178ac26 John Garry 2025-03-03 770 > > > > :::::: The code at line 746 was first introduced by commit > > :::::: 307185b178ac2695cbd964e9b0a5a9b7513bba93 xfs: Add xfs_file_dio_write_atomic() > > > > :::::: TO: John Garry <john.g.garry@oracle.com> > > :::::: CC: Carlos Maiolino <cem@kernel.org> > > > > -- > > 0-DAY CI Kernel Test Service > > https://github.com/intel/lkp-tests/wiki > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [xfs-linux:test-merge 13/13] fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 2025-03-10 9:39 ` Philip Li @ 2025-03-10 9:46 ` Carlos Maiolino 0 siblings, 0 replies; 4+ messages in thread From: Carlos Maiolino @ 2025-03-10 9:46 UTC (permalink / raw) To: Philip Li; +Cc: kernel test robot, llvm, oe-kbuild-all, linux-xfs On Mon, Mar 10, 2025 at 05:39:23PM +0800, Philip Li wrote: > On Mon, Mar 10, 2025 at 10:21:04AM +0100, Carlos Maiolino wrote: > > On Sun, Mar 09, 2025 at 01:06:40AM +0800, kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git test-merge > > > head: fac04210bb99888fd453db09239bed27436fd619 > > > commit: fac04210bb99888fd453db09239bed27436fd619 [13/13] Merge branch 'xfs-6.15-atomicwrites' into for-next > > > config: i386-buildonly-randconfig-003-20250308 (https://download.01.org/0day-ci/archive/20250309/202503090149.Wu0ag7zs-lkp@intel.com/config) > > > compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90) > > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250309/202503090149.Wu0ag7zs-lkp@intel.com/reproduce) > > > > Huh? All xfs branches are monitored? This was by no means to be tested. > > thanks for the info, we will ignore this test-merge branch to avoid sending > meaningless report. No need, I removed this branch already, this was just a temp merge. I expected that branches monitored by the bot were Opt-In by default. I'll just use my personal repo if I need to discuss a merge again. Carlos > > > > > Carlos > > > > > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > > the same patch/commit), kindly add following tags > > > | Reported-by: kernel test robot <lkp@intel.com> > > > | Closes: https://lore.kernel.org/oe-kbuild-all/202503090149.Wu0ag7zs-lkp@intel.com/ > > > > > > All errors (new ones prefixed by >>): > > > > > > >> fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 > > > 746 | ret = xfs_file_write_checks(iocb, from, &iolock); > > > | ~~~~~~~~~~~~~~~~~~~~~ ^ > > > fs/xfs/xfs_file.c:434:1: note: 'xfs_file_write_checks' declared here > > > 434 | xfs_file_write_checks( > > > | ^ > > > 435 | struct kiocb *iocb, > > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > 436 | struct iov_iter *from, > > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > 437 | unsigned int *iolock, > > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > 438 | struct xfs_zone_alloc_ctx *ac) > > > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > 1 error generated. > > > > > > > > > vim +746 fs/xfs/xfs_file.c > > > > > > 2e2383405824b9 Christoph Hellwig 2025-01-27 730 > > > 307185b178ac26 John Garry 2025-03-03 731 static noinline ssize_t > > > 307185b178ac26 John Garry 2025-03-03 732 xfs_file_dio_write_atomic( > > > 307185b178ac26 John Garry 2025-03-03 733 struct xfs_inode *ip, > > > 307185b178ac26 John Garry 2025-03-03 734 struct kiocb *iocb, > > > 307185b178ac26 John Garry 2025-03-03 735 struct iov_iter *from) > > > 307185b178ac26 John Garry 2025-03-03 736 { > > > 307185b178ac26 John Garry 2025-03-03 737 unsigned int iolock = XFS_IOLOCK_SHARED; > > > 307185b178ac26 John Garry 2025-03-03 738 unsigned int dio_flags = 0; > > > 307185b178ac26 John Garry 2025-03-03 739 ssize_t ret; > > > 307185b178ac26 John Garry 2025-03-03 740 > > > 307185b178ac26 John Garry 2025-03-03 741 retry: > > > 307185b178ac26 John Garry 2025-03-03 742 ret = xfs_ilock_iocb_for_write(iocb, &iolock); > > > 307185b178ac26 John Garry 2025-03-03 743 if (ret) > > > 307185b178ac26 John Garry 2025-03-03 744 return ret; > > > 307185b178ac26 John Garry 2025-03-03 745 > > > 307185b178ac26 John Garry 2025-03-03 @746 ret = xfs_file_write_checks(iocb, from, &iolock); > > > 307185b178ac26 John Garry 2025-03-03 747 if (ret) > > > 307185b178ac26 John Garry 2025-03-03 748 goto out_unlock; > > > 307185b178ac26 John Garry 2025-03-03 749 > > > 307185b178ac26 John Garry 2025-03-03 750 if (dio_flags & IOMAP_DIO_FORCE_WAIT) > > > 307185b178ac26 John Garry 2025-03-03 751 inode_dio_wait(VFS_I(ip)); > > > 307185b178ac26 John Garry 2025-03-03 752 > > > 307185b178ac26 John Garry 2025-03-03 753 trace_xfs_file_direct_write(iocb, from); > > > 307185b178ac26 John Garry 2025-03-03 754 ret = iomap_dio_rw(iocb, from, &xfs_atomic_write_iomap_ops, > > > 307185b178ac26 John Garry 2025-03-03 755 &xfs_dio_write_ops, dio_flags, NULL, 0); > > > 307185b178ac26 John Garry 2025-03-03 756 > > > 307185b178ac26 John Garry 2025-03-03 757 if (ret == -EAGAIN && !(iocb->ki_flags & IOCB_NOWAIT) && > > > 307185b178ac26 John Garry 2025-03-03 758 !(dio_flags & IOMAP_DIO_ATOMIC_SW)) { > > > 307185b178ac26 John Garry 2025-03-03 759 xfs_iunlock(ip, iolock); > > > 307185b178ac26 John Garry 2025-03-03 760 dio_flags = IOMAP_DIO_ATOMIC_SW | IOMAP_DIO_FORCE_WAIT; > > > 307185b178ac26 John Garry 2025-03-03 761 iolock = XFS_IOLOCK_EXCL; > > > 307185b178ac26 John Garry 2025-03-03 762 goto retry; > > > 307185b178ac26 John Garry 2025-03-03 763 } > > > 307185b178ac26 John Garry 2025-03-03 764 > > > 307185b178ac26 John Garry 2025-03-03 765 out_unlock: > > > 307185b178ac26 John Garry 2025-03-03 766 if (iolock) > > > 307185b178ac26 John Garry 2025-03-03 767 xfs_iunlock(ip, iolock); > > > 307185b178ac26 John Garry 2025-03-03 768 return ret; > > > 307185b178ac26 John Garry 2025-03-03 769 } > > > 307185b178ac26 John Garry 2025-03-03 770 > > > > > > :::::: The code at line 746 was first introduced by commit > > > :::::: 307185b178ac2695cbd964e9b0a5a9b7513bba93 xfs: Add xfs_file_dio_write_atomic() > > > > > > :::::: TO: John Garry <john.g.garry@oracle.com> > > > :::::: CC: Carlos Maiolino <cem@kernel.org> > > > > > > -- > > > 0-DAY CI Kernel Test Service > > > https://github.com/intel/lkp-tests/wiki > > > > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-10 9:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <PSt0U3K_mmDGWaUOdQei1VdlAVGOrC5kd15x-0yg_rquOtDV_Mh9rhn6hh7E2UkGEaAkraNnR5S41kzJkAmjMg==@protonmail.internalid>
2025-03-08 17:06 ` [xfs-linux:test-merge 13/13] fs/xfs/xfs_file.c:746:49: error: too few arguments to function call, expected 4, have 3 kernel test robot
2025-03-10 9:21 ` Carlos Maiolino
2025-03-10 9:39 ` Philip Li
2025-03-10 9:46 ` Carlos Maiolino
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox