Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: cleanup error tags v2
Date: Tue, 16 Sep 2025 09:28:13 -0700	[thread overview]
Message-ID: <20250916162843.258959-1-hch@lst.de> (raw)

Hi all,

while adding error injection to new code I'm writing I got really annoyed
with all the places error tags had to be added.  This series cleans the
error tags so that only the definition and one table have to be updated.
I've also cleaned up a lot of the surroundings while at it.

Changes since v1:
 - add a big fat comment and a idef/undef pair for the ERRTAGS magic

Diffstat:
 libxfs/xfs_ag_resv.c    |    7 -
 libxfs/xfs_alloc.c      |    5 -
 libxfs/xfs_attr_leaf.c  |    2 
 libxfs/xfs_bmap.c       |   17 +--
 libxfs/xfs_btree.c      |    2 
 libxfs/xfs_da_btree.c   |    2 
 libxfs/xfs_dir2.c       |    2 
 libxfs/xfs_errortag.h   |  106 +++++++++++++----------
 libxfs/xfs_exchmaps.c   |    4 
 libxfs/xfs_ialloc.c     |    2 
 libxfs/xfs_inode_buf.c  |    4 
 libxfs/xfs_inode_fork.c |    3 
 libxfs/xfs_metafile.c   |    2 
 libxfs/xfs_refcount.c   |    7 -
 libxfs/xfs_rmap.c       |    2 
 libxfs/xfs_rtbitmap.c   |    2 
 scrub/cow_repair.c      |    4 
 scrub/repair.c          |    2 
 xfs_attr_item.c         |    2 
 xfs_buf.c               |    4 
 xfs_error.c             |  216 ++++++------------------------------------------
 xfs_error.h             |   47 ++++------
 xfs_inode.c             |   28 ++----
 xfs_iomap.c             |    4 
 xfs_log.c               |    8 -
 xfs_trans_ail.c         |    2 
 26 files changed, 165 insertions(+), 321 deletions(-)

             reply	other threads:[~2025-09-16 16:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-16 16:28 Christoph Hellwig [this message]
2025-09-16 16:28 ` [PATCH 1/6] xfs: remove xfs_errortag_get Christoph Hellwig
2025-09-16 16:28 ` [PATCH 2/6] xfs: remove xfs_errortag_set Christoph Hellwig
2025-09-16 16:28 ` [PATCH 3/6] xfs: remove the expr argument to XFS_TEST_ERROR Christoph Hellwig
2025-09-16 16:28 ` [PATCH 4/6] xfs: remove pointless externs in xfs_error.h Christoph Hellwig
2025-09-16 16:28 ` [PATCH 5/6] xfs: centralize error tag definitions Christoph Hellwig
2025-09-16 16:38   ` Darrick J. Wong
2025-09-16 16:40     ` Christoph Hellwig
2025-09-16 16:46       ` Darrick J. Wong
2025-09-16 16:28 ` [PATCH 6/6] xfs: constify xfs_errortag_random_default Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250916162843.258959-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=cem@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox