Re: [PATCH 5/6] xfs: centralize error tag definitions

["Darrick J. Wong" <djwong@kernel.org>]

On Tue, Sep 16, 2025 at 06:40:57PM +0200, Christoph Hellwig wrote:
> On Tue, Sep 16, 2025 at 09:38:31AM -0700, Darrick J. Wong wrote:
> > > + * an XFS_ERRTAGS macro that expands to the XFS_ERRTAG macro supplied by the
> > > + * source files that includes this header use for each defined error
> > > + * injection knob.
> > 
> > Hmm, that last sentence could be more concise, and describe what is
> > passed to the XFS_ERRTAG macro:
> > 
> > "...will define an XFS_ERRTAGS macro that expands to invoke that
> > XFS_ERRTAG macro for each defined error injection knob.  The parameters
> > to the XFS_ERRTAG macro are:
> > 
> > 1. The XFS_ERRTAG_ flag but without the prefix;
> > 2. The name of the sysfs knob; and
> > 3. The default value for the knob."
> 
> That feels a bit too verbose for my taste, but if it helps I can change
> it.
> 
> > I wonder if XFS_ERRTAG() should be supplied with the full XFS_ERRTAG_FOO
> > name, not just FOO?
> 
> I did this initially, but it means very long lines that make the table
> rather hard to read.  So while I'm not a huge fan of magic symbol
> shortening I think it's fine here because the places that need to know
> about it are very confined.

Eh, you're right, there aren't that many places that are going to use
XFS_ERRTAGS.  Want to just make the last sentence of the comment read:

"...will define an XFS_ERRTAGS macro that expands to invoke that
XFS_ERRTAG macro for each defined error injection knob."

and then attach
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D