From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: Hans Holmberg <hans.holmberg@wdc.com>,
"Darrick J. Wong" <djwong@kernel.org>, Chris Mason <clm@meta.com>,
Keith Busch <kbusch@kernel.org>,
linux-xfs@vger.kernel.org
Subject: [PATCH 2/2] xfs: remove xfs_zone_gc_space_available
Date: Tue, 27 Jan 2026 16:10:21 +0100 [thread overview]
Message-ID: <20260127151026.299341-3-hch@lst.de> (raw)
In-Reply-To: <20260127151026.299341-1-hch@lst.de>
xfs_zone_gc_space_available only has one caller left, so fold it into
that. Reorder the checks so that the cheaper scratch_available check
is done first.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_zone_gc.c | 21 +++++++--------------
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
index 8c08e5519bff..7bdc5043cc1a 100644
--- a/fs/xfs/xfs_zone_gc.c
+++ b/fs/xfs/xfs_zone_gc.c
@@ -578,19 +578,6 @@ xfs_zone_gc_ensure_target(
return oz;
}
-static bool
-xfs_zone_gc_space_available(
- struct xfs_zone_gc_data *data)
-{
- struct xfs_open_zone *oz;
-
- oz = xfs_zone_gc_ensure_target(data->mp);
- if (!oz)
- return false;
- return oz->oz_allocated < rtg_blocks(oz->oz_rtg) &&
- data->scratch_available;
-}
-
static void
xfs_zone_gc_end_io(
struct bio *bio)
@@ -989,9 +976,15 @@ static bool
xfs_zone_gc_should_start_new_work(
struct xfs_zone_gc_data *data)
{
+ struct xfs_open_zone *oz;
+
if (xfs_is_shutdown(data->mp))
return false;
- if (!xfs_zone_gc_space_available(data))
+ if (!data->scratch_available)
+ return false;
+
+ oz = xfs_zone_gc_ensure_target(data->mp);
+ if (!oz || oz->oz_allocated == rtg_blocks(oz->oz_rtg))
return false;
if (!data->iter.victim_rtg) {
--
2.47.3
next prev parent reply other threads:[~2026-01-27 15:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 15:10 zone GC ringbuffer fix and cleanup Christoph Hellwig
2026-01-27 15:10 ` [PATCH 1/2] xfs: use a seprate member to track space availabe in the GC scatch buffer Christoph Hellwig
2026-01-28 5:35 ` Darrick J. Wong
2026-01-28 5:52 ` Christoph Hellwig
2026-01-28 5:56 ` Christoph Hellwig
2026-01-28 10:09 ` Carlos Maiolino
2026-01-28 12:00 ` Hans Holmberg
2026-01-29 11:32 ` Carlos Maiolino
2026-01-27 15:10 ` Christoph Hellwig [this message]
2026-01-28 12:02 ` [PATCH 2/2] xfs: remove xfs_zone_gc_space_available Hans Holmberg
2026-01-27 15:25 ` zone GC ringbuffer fix and cleanup Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127151026.299341-3-hch@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=clm@meta.com \
--cc=djwong@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox