From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cem@kernel.org>,
Hans Holmberg <hans.holmberg@wdc.com>,
"Darrick J. Wong" <djwong@kernel.org>, Chris Mason <clm@meta.com>,
linux-xfs@vger.kernel.org
Subject: Re: zone GC ringbuffer fix and cleanup
Date: Tue, 27 Jan 2026 08:25:21 -0700 [thread overview]
Message-ID: <aXjY4ZECqTxTQhTF@kbusch-mbp> (raw)
In-Reply-To: <20260127151026.299341-1-hch@lst.de>
On Tue, Jan 27, 2026 at 04:10:19PM +0100, Christoph Hellwig wrote:
> the first patch fixes the empty vs full condition detection in the ring
> buffer as noted by Chris. Keith had an alternative version that uses
> overflowing unsigned integer arithmetics, but just having an addition
> counter as in this version feels even simpler. The second one is a
> trivial cleanup in the same area.
I checked out these patches earlier directly from your tree, and these
look good to me.
Reviewed-by: Keith Busch <kbusch@kernel.org>
prev parent reply other threads:[~2026-01-27 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 15:10 zone GC ringbuffer fix and cleanup Christoph Hellwig
2026-01-27 15:10 ` [PATCH 1/2] xfs: use a seprate member to track space availabe in the GC scatch buffer Christoph Hellwig
2026-01-28 5:35 ` Darrick J. Wong
2026-01-28 5:52 ` Christoph Hellwig
2026-01-28 5:56 ` Christoph Hellwig
2026-01-28 10:09 ` Carlos Maiolino
2026-01-28 12:00 ` Hans Holmberg
2026-01-29 11:32 ` Carlos Maiolino
2026-01-27 15:10 ` [PATCH 2/2] xfs: remove xfs_zone_gc_space_available Christoph Hellwig
2026-01-28 12:02 ` Hans Holmberg
2026-01-27 15:25 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXjY4ZECqTxTQhTF@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=cem@kernel.org \
--cc=clm@meta.com \
--cc=djwong@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox