Linux XFS filesystem development
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Lukas Herbolt <lukas@herbolt.com>,
	linux-xfs@vger.kernel.org, cem@kernel.org
Subject: Re: [PATCH] xfs: Use xarray to track SB UUIDs instead of plain array.
Date: Mon, 2 Feb 2026 23:23:10 -0800	[thread overview]
Message-ID: <20260203072310.GC1535390@frogsfrogsfrogs> (raw)
In-Reply-To: <aYGE65iSRZWmxyVI@infradead.org>

On Mon, Feb 02, 2026 at 09:17:31PM -0800, Christoph Hellwig wrote:
> On Mon, Feb 02, 2026 at 10:50:13AM -0800, Darrick J. Wong wrote:
> > > I do not have strong preference here.
> > 
> > <shrug> Since the original message said "krealloc prints out warning if
> > allocation is bigger than 2x PAGE_SIZE", I figured that meant you were
> > trying to mount more than (2 * 4096) / 16 == 512 different xfs
> > filesystems on the same host.
> 
> I don't remember any such message.  But array or xarray iterations
> should still scale well enough for a single mount time operation into
> the 10.000nds of entries.
> 
> > I don't have a particular problem with the array search and large memory
> > allocation since I never mount that many filesystems, but you would
> > appear to be the first user to complain about a scaling limit there...
> 
> I was really just concerned about a single large allocation.  But yeah,
> it's not that large...  That beind said I think the xarray version will
> also look nicer than the original one.

It's better than the raw kvalloc'd blob we have now :)

--D

  reply	other threads:[~2026-02-03  7:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-30 15:42 [PATCH 0/1] xfs: Use xarray to track SB UUIDs instead of plain array Lukas Herbolt
2026-01-30 15:42 ` [PATCH] " Lukas Herbolt
2026-01-30 16:55   ` Darrick J. Wong
2026-02-02  7:31     ` Christoph Hellwig
2026-02-02  9:37       ` Lukas Herbolt
2026-02-02 18:50         ` Darrick J. Wong
2026-02-03  5:17           ` Christoph Hellwig
2026-02-03  7:23             ` Darrick J. Wong [this message]
2026-02-02  7:37   ` Christoph Hellwig
2026-02-02  9:38     ` Lukas Herbolt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203072310.GC1535390@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=cem@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=lukas@herbolt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox