From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Lukas Herbolt <lukas@herbolt.com>,
linux-xfs@vger.kernel.org, cem@kernel.org
Subject: Re: [PATCH] xfs: Use xarray to track SB UUIDs instead of plain array.
Date: Sun, 1 Feb 2026 23:31:26 -0800 [thread overview]
Message-ID: <aYBSzg3IhFffphuI@infradead.org> (raw)
In-Reply-To: <20260130165534.GG7712@frogsfrogsfrogs>
On Fri, Jan 30, 2026 at 08:55:34AM -0800, Darrick J. Wong wrote:
> > + xa_erase(&xfs_uuid_table, index);
> > + }
>
> Why not store the xarray index in the xfs_mount so you can delete the
> entry directly without having to walk the entire array?
Yeah, that makes a lot of sense.
> And while I'm on about it ... if you're going to change data structures,
> why not use rhashtable or something that can do a direct lookup?
rhashtables require quite a bit of boilerplate. Probably not worth
if for a single lookup in a relatively small colletion once per
mount. But yeah, if only we had a data structure that allows
directly lookups without all that boilerplate..
next prev parent reply other threads:[~2026-02-02 7:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 15:42 [PATCH 0/1] xfs: Use xarray to track SB UUIDs instead of plain array Lukas Herbolt
2026-01-30 15:42 ` [PATCH] " Lukas Herbolt
2026-01-30 16:55 ` Darrick J. Wong
2026-02-02 7:31 ` Christoph Hellwig [this message]
2026-02-02 9:37 ` Lukas Herbolt
2026-02-02 18:50 ` Darrick J. Wong
2026-02-03 5:17 ` Christoph Hellwig
2026-02-03 7:23 ` Darrick J. Wong
2026-02-02 7:37 ` Christoph Hellwig
2026-02-02 9:38 ` Lukas Herbolt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYBSzg3IhFffphuI@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lukas@herbolt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox