Re: [PATCH] xfs: improve RT geometry validation

["Darrick J. Wong" <djwong@kernel.org>]

On Fri, May 08, 2026 at 10:16:51AM +0200, Christoph Hellwig wrote:
> On Thu, May 07, 2026 at 10:17:58AM -0700, Darrick J. Wong wrote:
> > Isn't this already covered by xfs_validate_sb_rtgroups?
> 
> From a quick look it should...
> 
> > > -		div_u64_rem(sbp->sb_rextents, sbp->sb_rgextents, &mod);
> > > -		if (mod)
> > > +		if ((sbp->sb_features_incompat & XFS_SB_FEAT_INCOMPAT_ZONED) &&
> > > +		    mod > 0)
> > >  			return false;
> > 
> > And shouldn't this be in xfs_validate_sb_zoned?
> 
> This just slightly moves code.
> 
> > Or do you want this in xfs_validate_rt_geometry because that's what
> > xfs_repair calls to check the superblock?
> 
> I guess.  At least it was repair that went off on my badly messed up
> file system without this fix.
> 
> Maybe it's time to go back to the drawing board for the sb validation.

Yeah, it's unfortunate that xfs_repair duplicates most of that sb
validation code just so it can return an enum instead of xfs_err()ing
all over the place. :/

--D