Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cem@kernel.org>,
	fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] generic: add a test that stresses metadata eviction
Date: Tue, 19 May 2026 17:58:05 +0000	[thread overview]
Message-ID: <20260519175805.GA1875993@google.com> (raw)
In-Reply-To: <20260519083758.GA15916@lst.de>

On Tue, May 19, 2026 at 10:37:58AM +0200, Christoph Hellwig wrote:
> On Tue, May 19, 2026 at 03:03:37AM +0800, Zorro Lang wrote:
> > On Mon, May 18, 2026 at 02:27:42PM +0200, Carlos Maiolino wrote:
> > > On Mon, May 18, 2026 at 08:24:53AM +0200, Christoph Hellwig wrote:
> > > > The fsverity test generic/759 could be used to reproduce a regression in
> >                               ^^^
> >                               579
> 
> Yeah.
> 
> > Hmm... Generally, we state which case was copied/forked from in the introductory
> > comments of the case and in the commit log. If you want to specifically mention
> > the original author, I think we can add a dedicated line in the commit log, for
> > example:
> 
> If Eric is fine with that I can stick to the normal rule.
> 
> > What do you and others think?
> 
> I don't really care at all.  I just want to make sure I don't smub
> everyone involved with this the wrong way :)

The patch looks fine as-is (other than the typo already pointed out).
It already preserves the original copyright line and has a comment
"# Based on generic/579 with the fsverity bits stripped out".  I don't
need any additional credit.  Thanks,

- Eric

  reply	other threads:[~2026-05-19 17:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18  6:24 [PATCH] generic: add a test that stresses metadata eviction Christoph Hellwig
2026-05-18 12:27 ` Carlos Maiolino
2026-05-18 19:03   ` Zorro Lang
2026-05-19  8:37     ` Christoph Hellwig
2026-05-19 17:58       ` Eric Biggers [this message]
2026-05-19 20:47       ` Zorro Lang
2026-05-19 12:57     ` Theodore Tso
2026-05-19 20:39       ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519175805.GA1875993@google.com \
    --to=ebiggers@kernel.org \
    --cc=cem@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox