* zoned xfs updates
@ 2026-05-27 12:39 Christoph Hellwig
2026-05-27 12:39 ` [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry Christoph Hellwig
` (3 more replies)
0 siblings, 4 replies; 16+ messages in thread
From: Christoph Hellwig @ 2026-05-27 12:39 UTC (permalink / raw)
To: Carlos Maiolino; +Cc: Wilfred Mallawa, Damien Le Moal, Hans Holmberg, linux-xfs
Hi Carlos,
this series has a fix for an hamrless issue in a recent commit,
a cleanup, and then drops the experimental tag for the zoned
allocator now that it has been in an upstream release for a year.
Diffstat:
xfs_ioctl.c | 47 +++++++++++++++++++++++++++--------------------
xfs_message.c | 4 ----
xfs_message.h | 1 -
xfs_mount.h | 2 --
xfs_super.c | 1 -
5 files changed, 27 insertions(+), 28 deletions(-)
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry
2026-05-27 12:39 zoned xfs updates Christoph Hellwig
@ 2026-05-27 12:39 ` Christoph Hellwig
2026-05-27 18:00 ` Damien Le Moal
` (2 more replies)
2026-05-27 12:39 ` [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper Christoph Hellwig
` (2 subsequent siblings)
3 siblings, 3 replies; 16+ messages in thread
From: Christoph Hellwig @ 2026-05-27 12:39 UTC (permalink / raw)
To: Carlos Maiolino; +Cc: Wilfred Mallawa, Damien Le Moal, Hans Holmberg, linux-xfs
Keep the rtgroup reference until after reporting the write pointer, as
that uses it. Right now this is not a major issue as we don't support
shrinking file systems in a way that makes RTGs go away, but let's stick
to the proper reference counting to prepare for that.
Fixes: c6ce65cb17aa ("xfs: add write pointer to xfs_rtgroup_geometry")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_ioctl.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 46e234863644..737afcb5652a 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -433,9 +433,8 @@ xfs_ioc_rtgroup_geometry(
return -EINVAL;
error = xfs_rtgroup_get_geometry(rtg, &rgeo);
- xfs_rtgroup_put(rtg);
if (error)
- return error;
+ goto out_put_rtg;
if (xfs_has_zoned(mp)) {
xfs_rtgroup_lock(rtg, XFS_RTGLOCK_RMAP);
@@ -453,8 +452,10 @@ xfs_ioc_rtgroup_geometry(
}
if (copy_to_user(arg, &rgeo, sizeof(rgeo)))
- return -EFAULT;
- return 0;
+ error = -EFAULT;
+out_put_rtg:
+ xfs_rtgroup_put(rtg);
+ return error;
}
/*
--
2.53.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper
2026-05-27 12:39 zoned xfs updates Christoph Hellwig
2026-05-27 12:39 ` [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry Christoph Hellwig
@ 2026-05-27 12:39 ` Christoph Hellwig
2026-05-27 18:01 ` Damien Le Moal
` (2 more replies)
2026-05-27 12:39 ` [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator Christoph Hellwig
2026-05-30 6:40 ` zoned xfs updates Carlos Maiolino
3 siblings, 3 replies; 16+ messages in thread
From: Christoph Hellwig @ 2026-05-27 12:39 UTC (permalink / raw)
To: Carlos Maiolino; +Cc: Wilfred Mallawa, Damien Le Moal, Hans Holmberg, linux-xfs
Sticks out a bit better if we add a separate helper for it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_ioctl.c | 38 ++++++++++++++++++++++----------------
1 file changed, 22 insertions(+), 16 deletions(-)
diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
index 737afcb5652a..96af6b62ce39 100644
--- a/fs/xfs/xfs_ioctl.c
+++ b/fs/xfs/xfs_ioctl.c
@@ -409,6 +409,26 @@ xfs_ioc_ag_geometry(
return 0;
}
+static void
+xfs_rtgroup_report_write_pointer(
+ struct xfs_rtgroup *rtg,
+ struct xfs_rtgroup_geometry *rgeo)
+{
+ xfs_rtgroup_lock(rtg, XFS_RTGLOCK_RMAP);
+ if (rtg->rtg_open_zone) {
+ rgeo->rg_writepointer = rtg->rtg_open_zone->oz_allocated;
+ } else {
+ xfs_rgblock_t highest_rgbno = xfs_rtrmap_highest_rgbno(rtg);
+
+ if (highest_rgbno == NULLRGBLOCK)
+ rgeo->rg_writepointer = 0;
+ else
+ rgeo->rg_writepointer = highest_rgbno + 1;
+ }
+ xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_RMAP);
+ rgeo->rg_flags |= XFS_RTGROUP_GEOM_WRITEPOINTER;
+}
+
STATIC int
xfs_ioc_rtgroup_geometry(
struct xfs_mount *mp,
@@ -416,7 +436,6 @@ xfs_ioc_rtgroup_geometry(
{
struct xfs_rtgroup *rtg;
struct xfs_rtgroup_geometry rgeo;
- xfs_rgblock_t highest_rgbno;
int error;
if (copy_from_user(&rgeo, arg, sizeof(rgeo)))
@@ -435,21 +454,8 @@ xfs_ioc_rtgroup_geometry(
error = xfs_rtgroup_get_geometry(rtg, &rgeo);
if (error)
goto out_put_rtg;
-
- if (xfs_has_zoned(mp)) {
- xfs_rtgroup_lock(rtg, XFS_RTGLOCK_RMAP);
- if (rtg->rtg_open_zone) {
- rgeo.rg_writepointer = rtg->rtg_open_zone->oz_allocated;
- } else {
- highest_rgbno = xfs_rtrmap_highest_rgbno(rtg);
- if (highest_rgbno == NULLRGBLOCK)
- rgeo.rg_writepointer = 0;
- else
- rgeo.rg_writepointer = highest_rgbno + 1;
- }
- xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_RMAP);
- rgeo.rg_flags |= XFS_RTGROUP_GEOM_WRITEPOINTER;
- }
+ if (xfs_has_zoned(mp))
+ xfs_rtgroup_report_write_pointer(rtg, &rgeo);
if (copy_to_user(arg, &rgeo, sizeof(rgeo)))
error = -EFAULT;
--
2.53.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator
2026-05-27 12:39 zoned xfs updates Christoph Hellwig
2026-05-27 12:39 ` [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry Christoph Hellwig
2026-05-27 12:39 ` [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper Christoph Hellwig
@ 2026-05-27 12:39 ` Christoph Hellwig
2026-05-27 18:03 ` Damien Le Moal
` (2 more replies)
2026-05-30 6:40 ` zoned xfs updates Carlos Maiolino
3 siblings, 3 replies; 16+ messages in thread
From: Christoph Hellwig @ 2026-05-27 12:39 UTC (permalink / raw)
To: Carlos Maiolino; +Cc: Wilfred Mallawa, Damien Le Moal, Hans Holmberg, linux-xfs
The zoned allocator has been released with 6.15 on May 25, 2025. It has
seen constant maintenance and improvements and no major issues, so
promote it out of the experimental category.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_message.c | 4 ----
fs/xfs/xfs_message.h | 1 -
fs/xfs/xfs_mount.h | 2 --
fs/xfs/xfs_super.c | 1 -
4 files changed, 8 deletions(-)
diff --git a/fs/xfs/xfs_message.c b/fs/xfs/xfs_message.c
index fd297082aeb8..0243e509a468 100644
--- a/fs/xfs/xfs_message.c
+++ b/fs/xfs/xfs_message.c
@@ -149,10 +149,6 @@ xfs_warn_experimental(
.opstate = XFS_OPSTATE_WARNED_LARP,
.name = "logged extended attributes",
},
- [XFS_EXPERIMENTAL_ZONED] = {
- .opstate = XFS_OPSTATE_WARNED_ZONED,
- .name = "zoned RT device",
- },
};
ASSERT(feat >= 0 && feat < XFS_EXPERIMENTAL_MAX);
BUILD_BUG_ON(ARRAY_SIZE(features) != XFS_EXPERIMENTAL_MAX);
diff --git a/fs/xfs/xfs_message.h b/fs/xfs/xfs_message.h
index 49b0ef40d299..811b885f41c3 100644
--- a/fs/xfs/xfs_message.h
+++ b/fs/xfs/xfs_message.h
@@ -93,7 +93,6 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
enum xfs_experimental_feat {
XFS_EXPERIMENTAL_SHRINK,
XFS_EXPERIMENTAL_LARP,
- XFS_EXPERIMENTAL_ZONED,
XFS_EXPERIMENTAL_MAX,
};
diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
index d964bae096ef..66a02d1b9ad7 100644
--- a/fs/xfs/xfs_mount.h
+++ b/fs/xfs/xfs_mount.h
@@ -580,8 +580,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID)
#define XFS_OPSTATE_WARNED_METADIR 17
/* Filesystem should use qflags to determine quotaon status */
#define XFS_OPSTATE_RESUMING_QUOTAON 18
-/* Kernel has logged a warning about zoned RT device being used on this fs. */
-#define XFS_OPSTATE_WARNED_ZONED 19
/* (Zoned) GC is in progress */
#define XFS_OPSTATE_ZONEGC_RUNNING 20
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index f8de44443e81..eac7f9503805 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1901,7 +1901,6 @@ xfs_fs_fill_super(
error = -EINVAL;
goto out_filestream_unmount;
}
- xfs_warn_experimental(mp, XFS_EXPERIMENTAL_ZONED);
}
if (xfs_has_reflink(mp)) {
--
2.53.0
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry
2026-05-27 12:39 ` [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry Christoph Hellwig
@ 2026-05-27 18:00 ` Damien Le Moal
2026-05-27 22:33 ` Wilfred Mallawa
2026-05-28 8:13 ` Carlos Maiolino
2 siblings, 0 replies; 16+ messages in thread
From: Damien Le Moal @ 2026-05-27 18:00 UTC (permalink / raw)
To: Christoph Hellwig, Carlos Maiolino
Cc: Wilfred Mallawa, Hans Holmberg, linux-xfs
On 2026/05/27 21:39, Christoph Hellwig wrote:
> Keep the rtgroup reference until after reporting the write pointer, as
> that uses it. Right now this is not a major issue as we don't support
> shrinking file systems in a way that makes RTGs go away, but let's stick
> to the proper reference counting to prepare for that.
>
> Fixes: c6ce65cb17aa ("xfs: add write pointer to xfs_rtgroup_geometry")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper
2026-05-27 12:39 ` [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper Christoph Hellwig
@ 2026-05-27 18:01 ` Damien Le Moal
2026-05-27 22:36 ` Wilfred Mallawa
2026-05-28 8:14 ` Carlos Maiolino
2 siblings, 0 replies; 16+ messages in thread
From: Damien Le Moal @ 2026-05-27 18:01 UTC (permalink / raw)
To: Christoph Hellwig, Carlos Maiolino
Cc: Wilfred Mallawa, Hans Holmberg, linux-xfs
On 2026/05/27 21:39, Christoph Hellwig wrote:
> Sticks out a bit better if we add a separate helper for it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Nice cleanup!
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator
2026-05-27 12:39 ` [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator Christoph Hellwig
@ 2026-05-27 18:03 ` Damien Le Moal
2026-05-28 8:20 ` Carlos Maiolino
2026-05-27 22:38 ` Wilfred Mallawa
2026-05-28 8:16 ` Carlos Maiolino
2 siblings, 1 reply; 16+ messages in thread
From: Damien Le Moal @ 2026-05-27 18:03 UTC (permalink / raw)
To: Christoph Hellwig, Carlos Maiolino
Cc: Wilfred Mallawa, Hans Holmberg, linux-xfs
On 2026/05/27 21:39, Christoph Hellwig wrote:
> The zoned allocator has been released with 6.15 on May 25, 2025. It has
> seen constant maintenance and improvements and no major issues, so
> promote it out of the experimental category.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Yeah !
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
One nit below (feel free to ignore).
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index d964bae096ef..66a02d1b9ad7 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -580,8 +580,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID)
> #define XFS_OPSTATE_WARNED_METADIR 17
> /* Filesystem should use qflags to determine quotaon status */
> #define XFS_OPSTATE_RESUMING_QUOTAON 18
> -/* Kernel has logged a warning about zoned RT device being used on this fs. */
> -#define XFS_OPSTATE_WARNED_ZONED 19
> /* (Zoned) GC is in progress */
> #define XFS_OPSTATE_ZONEGC_RUNNING 20
Do we want to compact the numbering and change this to 19 ?
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry
2026-05-27 12:39 ` [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry Christoph Hellwig
2026-05-27 18:00 ` Damien Le Moal
@ 2026-05-27 22:33 ` Wilfred Mallawa
2026-05-28 8:13 ` Carlos Maiolino
2 siblings, 0 replies; 16+ messages in thread
From: Wilfred Mallawa @ 2026-05-27 22:33 UTC (permalink / raw)
To: hch@lst.de, cem@kernel.org
Cc: dlemoal@kernel.org, Hans Holmberg, linux-xfs@vger.kernel.org
On Wed, 2026-05-27 at 14:39 +0200, Christoph Hellwig wrote:
> Keep the rtgroup reference until after reporting the write pointer,
> as
> that uses it. Right now this is not a major issue as we don't
> support
> shrinking file systems in a way that makes RTGs go away, but let's
> stick
> to the proper reference counting to prepare for that.
>
> Fixes: c6ce65cb17aa ("xfs: add write pointer to
> xfs_rtgroup_geometry")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Cheers,
Wilfred
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper
2026-05-27 12:39 ` [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper Christoph Hellwig
2026-05-27 18:01 ` Damien Le Moal
@ 2026-05-27 22:36 ` Wilfred Mallawa
2026-05-28 8:14 ` Carlos Maiolino
2 siblings, 0 replies; 16+ messages in thread
From: Wilfred Mallawa @ 2026-05-27 22:36 UTC (permalink / raw)
To: hch@lst.de, cem@kernel.org
Cc: dlemoal@kernel.org, Hans Holmberg, linux-xfs@vger.kernel.org
On Wed, 2026-05-27 at 14:39 +0200, Christoph Hellwig wrote:
> Sticks out a bit better if we add a separate helper for it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Cheers,
Wilfred
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator
2026-05-27 12:39 ` [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator Christoph Hellwig
2026-05-27 18:03 ` Damien Le Moal
@ 2026-05-27 22:38 ` Wilfred Mallawa
2026-05-28 8:16 ` Carlos Maiolino
2 siblings, 0 replies; 16+ messages in thread
From: Wilfred Mallawa @ 2026-05-27 22:38 UTC (permalink / raw)
To: hch@lst.de, cem@kernel.org
Cc: dlemoal@kernel.org, Hans Holmberg, linux-xfs@vger.kernel.org
On Wed, 2026-05-27 at 14:39 +0200, Christoph Hellwig wrote:
> The zoned allocator has been released with 6.15 on May 25, 2025. It
> has
> seen constant maintenance and improvements and no major issues, so
> promote it out of the experimental category.
>
Nice 🎉️!
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
Cheers,
Wilfred
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry
2026-05-27 12:39 ` [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry Christoph Hellwig
2026-05-27 18:00 ` Damien Le Moal
2026-05-27 22:33 ` Wilfred Mallawa
@ 2026-05-28 8:13 ` Carlos Maiolino
2 siblings, 0 replies; 16+ messages in thread
From: Carlos Maiolino @ 2026-05-28 8:13 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Wilfred Mallawa, Damien Le Moal, Hans Holmberg, linux-xfs
On Wed, May 27, 2026 at 02:39:28PM +0200, Christoph Hellwig wrote:
> Keep the rtgroup reference until after reporting the write pointer, as
> that uses it. Right now this is not a major issue as we don't support
> shrinking file systems in a way that makes RTGs go away, but let's stick
> to the proper reference counting to prepare for that.
>
> Fixes: c6ce65cb17aa ("xfs: add write pointer to xfs_rtgroup_geometry")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/xfs/xfs_ioctl.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 46e234863644..737afcb5652a 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -433,9 +433,8 @@ xfs_ioc_rtgroup_geometry(
> return -EINVAL;
>
> error = xfs_rtgroup_get_geometry(rtg, &rgeo);
> - xfs_rtgroup_put(rtg);
> if (error)
> - return error;
> + goto out_put_rtg;
>
> if (xfs_has_zoned(mp)) {
> xfs_rtgroup_lock(rtg, XFS_RTGLOCK_RMAP);
> @@ -453,8 +452,10 @@ xfs_ioc_rtgroup_geometry(
> }
>
> if (copy_to_user(arg, &rgeo, sizeof(rgeo)))
> - return -EFAULT;
> - return 0;
> + error = -EFAULT;
> +out_put_rtg:
> + xfs_rtgroup_put(rtg);
> + return error;
> }
>
> /*
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper
2026-05-27 12:39 ` [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper Christoph Hellwig
2026-05-27 18:01 ` Damien Le Moal
2026-05-27 22:36 ` Wilfred Mallawa
@ 2026-05-28 8:14 ` Carlos Maiolino
2 siblings, 0 replies; 16+ messages in thread
From: Carlos Maiolino @ 2026-05-28 8:14 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Wilfred Mallawa, Damien Le Moal, Hans Holmberg, linux-xfs
On Wed, May 27, 2026 at 02:39:29PM +0200, Christoph Hellwig wrote:
> Sticks out a bit better if we add a separate helper for it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/xfs/xfs_ioctl.c | 38 ++++++++++++++++++++++----------------
> 1 file changed, 22 insertions(+), 16 deletions(-)
>
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 737afcb5652a..96af6b62ce39 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -409,6 +409,26 @@ xfs_ioc_ag_geometry(
> return 0;
> }
>
> +static void
> +xfs_rtgroup_report_write_pointer(
> + struct xfs_rtgroup *rtg,
> + struct xfs_rtgroup_geometry *rgeo)
> +{
> + xfs_rtgroup_lock(rtg, XFS_RTGLOCK_RMAP);
> + if (rtg->rtg_open_zone) {
> + rgeo->rg_writepointer = rtg->rtg_open_zone->oz_allocated;
> + } else {
> + xfs_rgblock_t highest_rgbno = xfs_rtrmap_highest_rgbno(rtg);
> +
> + if (highest_rgbno == NULLRGBLOCK)
> + rgeo->rg_writepointer = 0;
> + else
> + rgeo->rg_writepointer = highest_rgbno + 1;
> + }
> + xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_RMAP);
> + rgeo->rg_flags |= XFS_RTGROUP_GEOM_WRITEPOINTER;
> +}
> +
> STATIC int
> xfs_ioc_rtgroup_geometry(
> struct xfs_mount *mp,
> @@ -416,7 +436,6 @@ xfs_ioc_rtgroup_geometry(
> {
> struct xfs_rtgroup *rtg;
> struct xfs_rtgroup_geometry rgeo;
> - xfs_rgblock_t highest_rgbno;
> int error;
>
> if (copy_from_user(&rgeo, arg, sizeof(rgeo)))
> @@ -435,21 +454,8 @@ xfs_ioc_rtgroup_geometry(
> error = xfs_rtgroup_get_geometry(rtg, &rgeo);
> if (error)
> goto out_put_rtg;
> -
> - if (xfs_has_zoned(mp)) {
> - xfs_rtgroup_lock(rtg, XFS_RTGLOCK_RMAP);
> - if (rtg->rtg_open_zone) {
> - rgeo.rg_writepointer = rtg->rtg_open_zone->oz_allocated;
> - } else {
> - highest_rgbno = xfs_rtrmap_highest_rgbno(rtg);
> - if (highest_rgbno == NULLRGBLOCK)
> - rgeo.rg_writepointer = 0;
> - else
> - rgeo.rg_writepointer = highest_rgbno + 1;
> - }
> - xfs_rtgroup_unlock(rtg, XFS_RTGLOCK_RMAP);
> - rgeo.rg_flags |= XFS_RTGROUP_GEOM_WRITEPOINTER;
> - }
> + if (xfs_has_zoned(mp))
> + xfs_rtgroup_report_write_pointer(rtg, &rgeo);
>
> if (copy_to_user(arg, &rgeo, sizeof(rgeo)))
> error = -EFAULT;
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator
2026-05-27 12:39 ` [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator Christoph Hellwig
2026-05-27 18:03 ` Damien Le Moal
2026-05-27 22:38 ` Wilfred Mallawa
@ 2026-05-28 8:16 ` Carlos Maiolino
2 siblings, 0 replies; 16+ messages in thread
From: Carlos Maiolino @ 2026-05-28 8:16 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Wilfred Mallawa, Damien Le Moal, Hans Holmberg, linux-xfs
On Wed, May 27, 2026 at 02:39:30PM +0200, Christoph Hellwig wrote:
> The zoned allocator has been released with 6.15 on May 25, 2025. It has
> seen constant maintenance and improvements and no major issues, so
> promote it out of the experimental category.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Agreed, I'll queue this one to 7.2 merge window.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> fs/xfs/xfs_message.c | 4 ----
> fs/xfs/xfs_message.h | 1 -
> fs/xfs/xfs_mount.h | 2 --
> fs/xfs/xfs_super.c | 1 -
> 4 files changed, 8 deletions(-)
>
> diff --git a/fs/xfs/xfs_message.c b/fs/xfs/xfs_message.c
> index fd297082aeb8..0243e509a468 100644
> --- a/fs/xfs/xfs_message.c
> +++ b/fs/xfs/xfs_message.c
> @@ -149,10 +149,6 @@ xfs_warn_experimental(
> .opstate = XFS_OPSTATE_WARNED_LARP,
> .name = "logged extended attributes",
> },
> - [XFS_EXPERIMENTAL_ZONED] = {
> - .opstate = XFS_OPSTATE_WARNED_ZONED,
> - .name = "zoned RT device",
> - },
> };
> ASSERT(feat >= 0 && feat < XFS_EXPERIMENTAL_MAX);
> BUILD_BUG_ON(ARRAY_SIZE(features) != XFS_EXPERIMENTAL_MAX);
> diff --git a/fs/xfs/xfs_message.h b/fs/xfs/xfs_message.h
> index 49b0ef40d299..811b885f41c3 100644
> --- a/fs/xfs/xfs_message.h
> +++ b/fs/xfs/xfs_message.h
> @@ -93,7 +93,6 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
> enum xfs_experimental_feat {
> XFS_EXPERIMENTAL_SHRINK,
> XFS_EXPERIMENTAL_LARP,
> - XFS_EXPERIMENTAL_ZONED,
>
> XFS_EXPERIMENTAL_MAX,
> };
> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> index d964bae096ef..66a02d1b9ad7 100644
> --- a/fs/xfs/xfs_mount.h
> +++ b/fs/xfs/xfs_mount.h
> @@ -580,8 +580,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID)
> #define XFS_OPSTATE_WARNED_METADIR 17
> /* Filesystem should use qflags to determine quotaon status */
> #define XFS_OPSTATE_RESUMING_QUOTAON 18
> -/* Kernel has logged a warning about zoned RT device being used on this fs. */
> -#define XFS_OPSTATE_WARNED_ZONED 19
> /* (Zoned) GC is in progress */
> #define XFS_OPSTATE_ZONEGC_RUNNING 20
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index f8de44443e81..eac7f9503805 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1901,7 +1901,6 @@ xfs_fs_fill_super(
> error = -EINVAL;
> goto out_filestream_unmount;
> }
> - xfs_warn_experimental(mp, XFS_EXPERIMENTAL_ZONED);
> }
>
> if (xfs_has_reflink(mp)) {
> --
> 2.53.0
>
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator
2026-05-27 18:03 ` Damien Le Moal
@ 2026-05-28 8:20 ` Carlos Maiolino
2026-05-28 8:25 ` Christoph Hellwig
0 siblings, 1 reply; 16+ messages in thread
From: Carlos Maiolino @ 2026-05-28 8:20 UTC (permalink / raw)
To: Damien Le Moal
Cc: Christoph Hellwig, Wilfred Mallawa, Hans Holmberg, linux-xfs
On Thu, May 28, 2026 at 03:03:41AM +0900, Damien Le Moal wrote:
> On 2026/05/27 21:39, Christoph Hellwig wrote:
> > The zoned allocator has been released with 6.15 on May 25, 2025. It has
> > seen constant maintenance and improvements and no major issues, so
> > promote it out of the experimental category.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Yeah !
>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
>
> One nit below (feel free to ignore).
>
> > diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
> > index d964bae096ef..66a02d1b9ad7 100644
> > --- a/fs/xfs/xfs_mount.h
> > +++ b/fs/xfs/xfs_mount.h
> > @@ -580,8 +580,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID)
> > #define XFS_OPSTATE_WARNED_METADIR 17
> > /* Filesystem should use qflags to determine quotaon status */
> > #define XFS_OPSTATE_RESUMING_QUOTAON 18
> > -/* Kernel has logged a warning about zoned RT device being used on this fs. */
> > -#define XFS_OPSTATE_WARNED_ZONED 19
> > /* (Zoned) GC is in progress */
> > #define XFS_OPSTATE_ZONEGC_RUNNING 20
>
> Do we want to compact the numbering and change this to 19 ?
I'd agree with Christoph and not reuse the warn number but perhaps I'm
just being overly cautious as we don't have a 'stable' version which
zoned support would be backported to :P
>
>
> --
> Damien Le Moal
> Western Digital Research
>
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator
2026-05-28 8:20 ` Carlos Maiolino
@ 2026-05-28 8:25 ` Christoph Hellwig
0 siblings, 0 replies; 16+ messages in thread
From: Christoph Hellwig @ 2026-05-28 8:25 UTC (permalink / raw)
To: Carlos Maiolino
Cc: Damien Le Moal, Christoph Hellwig, Wilfred Mallawa, Hans Holmberg,
linux-xfs
On Thu, May 28, 2026 at 10:20:52AM +0200, Carlos Maiolino wrote:
> > Do we want to compact the numbering and change this to 19 ?
>
> I'd agree with Christoph and not reuse the warn number but perhaps I'm
> just being overly cautious as we don't have a 'stable' version which
> zoned support would be backported to :P
There's a lot of holes in this number space. I can send an incremental
patch to compact it.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: zoned xfs updates
2026-05-27 12:39 zoned xfs updates Christoph Hellwig
` (2 preceding siblings ...)
2026-05-27 12:39 ` [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator Christoph Hellwig
@ 2026-05-30 6:40 ` Carlos Maiolino
3 siblings, 0 replies; 16+ messages in thread
From: Carlos Maiolino @ 2026-05-30 6:40 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Wilfred Mallawa, Damien Le Moal, Hans Holmberg, linux-xfs
On Wed, 27 May 2026 14:39:27 +0200, Christoph Hellwig wrote:
> this series has a fix for an hamrless issue in a recent commit,
> a cleanup, and then drops the experimental tag for the zoned
> allocator now that it has been in an upstream release for a year.
>
> Diffstat:
> xfs_ioctl.c | 47 +++++++++++++++++++++++++++--------------------
> xfs_message.c | 4 ----
> xfs_message.h | 1 -
> xfs_mount.h | 2 --
> xfs_super.c | 1 -
> 5 files changed, 27 insertions(+), 28 deletions(-)
>
> [...]
Applied to for-next, thanks!
[1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry
commit: c316bb56bf4dda9bd3456a163c3a3856ca1b9498
[2/3] xfs: factor rtgroup geom write pointer reporting into a helper
commit: 2fa29c1a167739fdef0fda9742ddeb15d9a6c7e4
[3/3] xfs: drop the experimental warning for the zoned allocator
(no commit info)
Best regards,
--
Carlos Maiolino <cem@kernel.org>
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2026-05-30 6:40 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-27 12:39 zoned xfs updates Christoph Hellwig
2026-05-27 12:39 ` [PATCH 1/3] xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry Christoph Hellwig
2026-05-27 18:00 ` Damien Le Moal
2026-05-27 22:33 ` Wilfred Mallawa
2026-05-28 8:13 ` Carlos Maiolino
2026-05-27 12:39 ` [PATCH 2/3] xfs: factor rtgroup geom write pointer reporting into a helper Christoph Hellwig
2026-05-27 18:01 ` Damien Le Moal
2026-05-27 22:36 ` Wilfred Mallawa
2026-05-28 8:14 ` Carlos Maiolino
2026-05-27 12:39 ` [PATCH 3/3] xfs: drop the experimental warning for the zoned allocator Christoph Hellwig
2026-05-27 18:03 ` Damien Le Moal
2026-05-28 8:20 ` Carlos Maiolino
2026-05-28 8:25 ` Christoph Hellwig
2026-05-27 22:38 ` Wilfred Mallawa
2026-05-28 8:16 ` Carlos Maiolino
2026-05-30 6:40 ` zoned xfs updates Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox