From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cem@kernel.org>,
Damien Le Moal <dlemoal@kernel.org>,
Hans Holmberg <hans.holmberg@wdc.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: account newly added RTGs as free zones in growfs
Date: Tue, 9 Jun 2026 07:54:54 -0700 [thread overview]
Message-ID: <20260609145454.GA6078@frogsfrogsfrogs> (raw)
In-Reply-To: <20260609075655.1698743-3-hch@lst.de>
On Tue, Jun 09, 2026 at 09:56:42AM +0200, Christoph Hellwig wrote:
> When growing a zoned RT section, the newly added RTGs also need to be
> tagged as free in the radix tree and add to the nr_free_zones counters.
> Call xfs_add_free_zone to do that, otherwise using up the newly added
> space will wait for free zones forever.
>
> Fixes: 01b71e64bb87 ("xfs: support growfs on zoned file systems")
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Good catch; glad there's a new fstest for it.
Cc: <stable@vger.kernel.org> # v6.15
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> fs/xfs/xfs_rtalloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index 153f3c378f9f..fd07c1a18615 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -933,6 +933,7 @@ xfs_growfs_rt_zoned(
> mp->m_features |= XFS_FEAT_REALTIME;
> xfs_rtrmapbt_compute_maxlevels(mp);
> xfs_rtrefcountbt_compute_maxlevels(mp);
> + xfs_add_free_zone(rtg);
> xfs_zoned_add_available(mp, freed_rtx);
> out_free:
> kfree(nmp);
> --
> 2.53.0
>
>
next prev parent reply other threads:[~2026-06-09 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 7:56 zoned growfs fix Christoph Hellwig
2026-06-09 7:56 ` [PATCH 1/3] xfs: factor out a xfs_add_free_zone helper Christoph Hellwig
2026-06-09 14:56 ` Darrick J. Wong
2026-06-09 23:17 ` Damien Le Moal
2026-06-09 7:56 ` [PATCH 2/3] xfs: account newly added RTGs as free zones in growfs Christoph Hellwig
2026-06-09 14:54 ` Darrick J. Wong [this message]
2026-06-09 23:18 ` Damien Le Moal
2026-06-09 7:56 ` [PATCH 3/3] xfs: only log freed extents for the current RTG in zoned growfs Christoph Hellwig
2026-06-09 14:54 ` Darrick J. Wong
2026-06-09 23:20 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609145454.GA6078@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=dlemoal@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox