Linux XFS filesystem development
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Carlos Maiolino <cem@kernel.org>
Cc: Hans Holmberg <hans.holmberg@wdc.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/3] xfs: factor out a xfs_add_free_zone helper
Date: Wed, 10 Jun 2026 07:17:52 +0800	[thread overview]
Message-ID: <22a1d379-cea7-431d-ab5f-449bae98e2bd@kernel.org> (raw)
In-Reply-To: <20260609075655.1698743-2-hch@lst.de>

On 2026/06/09 15:56, Christoph Hellwig wrote:
> Add a helper for adding a zone to the free pool in preparation of adding
> another caller.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Same comment as Darrick: to match xfs_group_set_mark(), xfs_mark_zone_free() or
xfs_zone_mark_free() may be a better name.
Other than that,

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>


-- 
Damien Le Moal
Western Digital Research

  parent reply	other threads:[~2026-06-09 23:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09  7:56 zoned growfs fix Christoph Hellwig
2026-06-09  7:56 ` [PATCH 1/3] xfs: factor out a xfs_add_free_zone helper Christoph Hellwig
2026-06-09 14:56   ` Darrick J. Wong
2026-06-09 23:17   ` Damien Le Moal [this message]
2026-06-09  7:56 ` [PATCH 2/3] xfs: account newly added RTGs as free zones in growfs Christoph Hellwig
2026-06-09 14:54   ` Darrick J. Wong
2026-06-09 23:18   ` Damien Le Moal
2026-06-09  7:56 ` [PATCH 3/3] xfs: only log freed extents for the current RTG in zoned growfs Christoph Hellwig
2026-06-09 14:54   ` Darrick J. Wong
2026-06-09 23:20   ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22a1d379-cea7-431d-ab5f-449bae98e2bd@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cem@kernel.org \
    --cc=hans.holmberg@wdc.com \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox