From: "Darrick J. Wong" <djwong@kernel.org>
To: liuh <liuhuan01@kylinos.cn>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] mkfs: remove duplicate include of convert.h
Date: Wed, 24 Jun 2026 10:09:55 -0700 [thread overview]
Message-ID: <20260624170955.GN6078@frogsfrogsfrogs> (raw)
In-Reply-To: <20260622024311.26681-1-liuhuan01@kylinos.cn>
On Mon, Jun 22, 2026 at 10:43:11AM +0800, liuh wrote:
> The header file "libfrog/convert.h" is included twice in xfs_mkfs.c.
> Clean it up by removing the redundant second inclusion.
>
> Signed-off-by: liuh <liuhuan01@kylinos.cn>
Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> mkfs/xfs_mkfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index dd8a48c3..64e8a6a6 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -15,7 +15,6 @@
> #include "libfrog/dahashselftest.h"
> #include "libfrog/fsproperties.h"
> #include "libfrog/zones.h"
> -#include "libfrog/convert.h"
> #include "proto.h"
> #include <ini.h>
>
> --
> 2.43.0
>
>
next prev parent reply other threads:[~2026-06-24 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 2:43 [PATCH] mkfs: remove duplicate include of convert.h liuh
2026-06-24 17:09 ` Darrick J. Wong [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-22 2:43 liuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260624170955.GN6078@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=liuhuan01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox