* [PATCH] mkfs: remove duplicate include of convert.h
@ 2026-06-22 2:43 liuh
2026-06-24 17:09 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: liuh @ 2026-06-22 2:43 UTC (permalink / raw)
To: djwong; +Cc: linux-xfs, liuh
The header file "libfrog/convert.h" is included twice in xfs_mkfs.c.
Clean it up by removing the redundant second inclusion.
Signed-off-by: liuh <liuhuan01@kylinos.cn>
---
mkfs/xfs_mkfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index dd8a48c3..64e8a6a6 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -15,7 +15,6 @@
#include "libfrog/dahashselftest.h"
#include "libfrog/fsproperties.h"
#include "libfrog/zones.h"
-#include "libfrog/convert.h"
#include "proto.h"
#include <ini.h>
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mkfs: remove duplicate include of convert.h
2026-06-22 2:43 [PATCH] mkfs: remove duplicate include of convert.h liuh
@ 2026-06-24 17:09 ` Darrick J. Wong
0 siblings, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2026-06-24 17:09 UTC (permalink / raw)
To: liuh; +Cc: linux-xfs
On Mon, Jun 22, 2026 at 10:43:11AM +0800, liuh wrote:
> The header file "libfrog/convert.h" is included twice in xfs_mkfs.c.
> Clean it up by removing the redundant second inclusion.
>
> Signed-off-by: liuh <liuhuan01@kylinos.cn>
Looks ok,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> mkfs/xfs_mkfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index dd8a48c3..64e8a6a6 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -15,7 +15,6 @@
> #include "libfrog/dahashselftest.h"
> #include "libfrog/fsproperties.h"
> #include "libfrog/zones.h"
> -#include "libfrog/convert.h"
> #include "proto.h"
> #include <ini.h>
>
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] mkfs: remove duplicate include of convert.h
@ 2026-06-22 2:43 liuh
0 siblings, 0 replies; 3+ messages in thread
From: liuh @ 2026-06-22 2:43 UTC (permalink / raw)
To: djwong; +Cc: linux-xfs, liuh
The header file "libfrog/convert.h" is included twice in xfs_mkfs.c.
Clean it up by removing the redundant second inclusion.
Signed-off-by: liuh <liuhuan01@kylinos.cn>
---
mkfs/xfs_mkfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index dd8a48c3..64e8a6a6 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -15,7 +15,6 @@
#include "libfrog/dahashselftest.h"
#include "libfrog/fsproperties.h"
#include "libfrog/zones.h"
-#include "libfrog/convert.h"
#include "proto.h"
#include <ini.h>
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-24 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-22 2:43 [PATCH] mkfs: remove duplicate include of convert.h liuh
2026-06-24 17:09 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2026-06-22 2:43 liuh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox