[PATCH] fsr: preserve xfrog_bulkstat error codes

[PATCH] fsr: preserve xfrog_bulkstat error codes

[liuh]

Fix the bulkstat loop condition in fsrfs() to assign the return
value of xfrog_bulkstat() to ret before comparing it against zero.

Without the extra parentheses, operator precedence causes ret
to receive only the result of the comparison (0 or 1), which
discards the actual error code and breaks error reporting.

Signed-off-by: liuh <liuhuan01@kylinos.cn>
---
 fsr/xfs_fsr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
index e74180c1..68cc0ea4 100644
--- a/fsr/xfs_fsr.c
+++ b/fsr/xfs_fsr.c
@@ -678,7 +678,7 @@ fsrfs(char *mntdir, xfs_ino_t startino, int targetrange)
 		return -1;
 	}
 
-	while ((ret = -xfrog_bulkstat(&fsxfd, breq) == 0)) {
+	while ((ret = -xfrog_bulkstat(&fsxfd, breq)) == 0) {
 		struct xfs_bulkstat	*buf = breq->bulkstat;
 		struct xfs_bulkstat	*p;
 		struct xfs_bulkstat	*endp;
-- 
2.43.0

Re: [PATCH] fsr: preserve xfrog_bulkstat error codes

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] fsr: preserve xfrog_bulkstat error codes

[Darrick J. Wong]

On Wed, Jun 24, 2026 at 04:11:35PM +0800, liuh wrote:
> Fix the bulkstat loop condition in fsrfs() to assign the return
> value of xfrog_bulkstat() to ret before comparing it against zero.
> 
> Without the extra parentheses, operator precedence causes ret
> to receive only the result of the comparison (0 or 1), which
> discards the actual error code and breaks error reporting.
> 
> Signed-off-by: liuh <liuhuan01@kylinos.cn>
> ---
>  fsr/xfs_fsr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
> index e74180c1..68cc0ea4 100644
> --- a/fsr/xfs_fsr.c
> +++ b/fsr/xfs_fsr.c
> @@ -678,7 +678,7 @@ fsrfs(char *mntdir, xfs_ino_t startino, int targetrange)
>  		return -1;
>  	}
>  
> -	while ((ret = -xfrog_bulkstat(&fsxfd, breq) == 0)) {
> +	while ((ret = -xfrog_bulkstat(&fsxfd, breq)) == 0) {

Heh, oops.

Cc: <linux-xfs@vger.kernel.org> # v5.3.0
Fixes: e6542132dec3cd ("libfrog: convert bulkstat.c functions to negative error codes")

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

>  		struct xfs_bulkstat	*buf = breq->bulkstat;
>  		struct xfs_bulkstat	*p;
>  		struct xfs_bulkstat	*endp;
> -- 
> 2.43.0
> 
>