From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: aalbersh@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 04/11] xfs_scrub: track inode scan abort state with an enum
Date: Thu, 25 Jun 2026 15:31:53 -0700 [thread overview]
Message-ID: <20260625223153.GL6078@frogsfrogsfrogs> (raw)
In-Reply-To: <20260625120213.GE18766@lst.de>
On Thu, Jun 25, 2026 at 02:02:13PM +0200, Christoph Hellwig wrote:
> On Wed, Jun 24, 2026 at 11:15:33AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Change this from a boolean to an enum so that we can handle scan
> > cancellations correctly in the next patch.
>
> Where that means adding a new member to the enum I guess? I'd probaby
Yep.
> merge the patches for easier understanding, but the change itself does
> look ok:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks!
--D
next prev parent reply other threads:[~2026-06-25 22:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 18:14 [PATCHSET] xfs_scrub: codex-inspired bug fixes, part 2 Darrick J. Wong
2026-06-24 18:14 ` [PATCH 01/11] xfs_scrub: handle missing media verify ioctl failure return codes Darrick J. Wong
2026-06-25 12:00 ` Christoph Hellwig
2026-06-24 18:15 ` [PATCH 02/11] xfs_scrub: report bad file ranges correctly Darrick J. Wong
2026-06-25 12:00 ` Christoph Hellwig
2026-06-24 18:15 ` [PATCH 03/11] xfs_scrub: handle media scans of internal rt devices correctly Darrick J. Wong
2026-06-25 12:01 ` Christoph Hellwig
2026-06-25 22:48 ` Darrick J. Wong
2026-06-26 4:50 ` Christoph Hellwig
2026-06-24 18:15 ` [PATCH 04/11] xfs_scrub: track inode scan abort state with an enum Darrick J. Wong
2026-06-25 12:02 ` Christoph Hellwig
2026-06-25 22:31 ` Darrick J. Wong [this message]
2026-06-24 18:15 ` [PATCH 05/11] xfs_scrub: don't skip bulkstat batch when scrub_scan_user_files helper returns ESTALE Darrick J. Wong
2026-06-25 12:03 ` Christoph Hellwig
2026-06-24 18:16 ` [PATCH 06/11] xfs_scrub: warn about incomplete repairs if we never get to them Darrick J. Wong
2026-06-25 12:03 ` Christoph Hellwig
2026-06-24 18:16 ` [PATCH 07/11] xfs_scrub: report external log space usage in phase 7 Darrick J. Wong
2026-06-25 12:05 ` Christoph Hellwig
2026-06-24 18:16 ` [PATCH 08/11] xfs_scrub: account only data extent tail after an overlap Darrick J. Wong
2026-06-25 12:05 ` Christoph Hellwig
2026-06-24 18:16 ` [PATCH 09/11] xfs_scrub: account for reflinked realtime file data Darrick J. Wong
2026-06-25 12:06 ` Christoph Hellwig
2026-06-24 18:17 ` [PATCH 10/11] xfs_scrub: don't leak the autofsck fsproperty handle Darrick J. Wong
2026-06-25 12:06 ` Christoph Hellwig
2026-06-24 18:17 ` [PATCH 11/11] xfs_scrub: warn about difficult rtgroup repairs Darrick J. Wong
2026-06-25 12:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260625223153.GL6078@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=aalbersh@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox