From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Christian Brauner <brauner@kernel.org>,
Kelu Ye <yekelu1@huawei.com>, Yifan Zhao <zhaoyifan28@huawei.com>,
Ritesh Harjani <ritesh.list@gmail.com>,
Joanne Koong <joannelkoong@gmail.com>,
Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
Hyunchul Lee <hyc.lee@gmail.com>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
Miklos Szeredi <miklos@szeredi.hu>,
fuse-devel@lists.linux.dev, ntfs3@lists.linux.dev,
linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] iomap: consolidate bio submission
Date: Fri, 26 Jun 2026 06:30:03 +0200 [thread overview]
Message-ID: <20260626043003.GA8078@lst.de> (raw)
In-Reply-To: <20260625172740.GD6078@frogsfrogsfrogs>
On Thu, Jun 25, 2026 at 10:27:40AM -0700, Darrick J. Wong wrote:
> >
> > + bio->bi_end_io = end_io;
> > if (iter->iomap.flags & IOMAP_F_INTEGRITY)
> > fs_bio_integrity_alloc(bio);
>
> Ah, so the bug here is that all the pagecache readers should have been
> allocating integrity information for the bio before submitting it?
Well, all the ones that set IOMAP_F_INTEGRITY, which really is just
XFS at the momen. And because if the iomap refactoring for fuse XFS
is now using it's own submit callback and does not get it..
> And
> because it doesn't, iomap_finish_ioend won't do the read verification?
Yeah.
> So the block layer does it for us, and that's why we don't use the ioend
> chaining? And (I guess) the future userspace interface won't have any
> means to get at the integrity data?
Yeah.
next prev parent reply other threads:[~2026-06-26 4:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 12:07 don't build bios/contexts over multiple iomaps v3 Christoph Hellwig
2026-06-25 12:07 ` [PATCH 1/2] iomap: consolidate bio submission Christoph Hellwig
2026-06-25 17:27 ` Darrick J. Wong
2026-06-26 4:30 ` Christoph Hellwig [this message]
2026-06-25 12:07 ` [PATCH 2/2] iomap: submit read bio after each extent Christoph Hellwig
2026-06-25 17:47 ` Darrick J. Wong
2026-06-25 18:32 ` Joanne Koong
2026-06-26 4:33 ` Christoph Hellwig
2026-06-26 6:16 ` Christoph Hellwig
2026-06-26 6:20 ` Darrick J. Wong
2026-06-26 14:51 ` Joanne Koong
2026-06-26 4:31 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2026-06-23 13:51 don't build bios/contexts over multiple iomaps v2 Christoph Hellwig
2026-06-23 13:51 ` [PATCH 1/2] iomap: consolidate bio submission Christoph Hellwig
2026-06-23 17:04 ` Joanne Koong
2026-06-23 23:57 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260626043003.GA8078@lst.de \
--to=hch@lst.de \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=fuse-devel@lists.linux.dev \
--cc=hyc.lee@gmail.com \
--cc=joannelkoong@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=ntfs3@lists.linux.dev \
--cc=ritesh.list@gmail.com \
--cc=sj1557.seo@samsung.com \
--cc=yekelu1@huawei.com \
--cc=zhaoyifan28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox