Linux XFS filesystem development
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@kernel.org, fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 2/2] xfs/65[56]: don't unset SCRATCH_RTDEV here
Date: Wed, 1 Jul 2026 20:57:59 -0700	[thread overview]
Message-ID: <20260702035759.GB9381@frogsfrogsfrogs> (raw)
In-Reply-To: <20260702035523.GA9381@frogsfrogsfrogs>

From: Darrick J. Wong <djwong@kernel.org>

Both of these tests claim that they have to unset SCRATCH_RTDEV to avoid
formatting failures due to the rt bitmap consuming all the space in the
"small" data device.  However, the format doesn't constrain the size of
the data device, so the justification doesn't apply.  Remove the whole
thing.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 tests/xfs/655 |    4 ----
 tests/xfs/656 |    4 ----
 2 files changed, 8 deletions(-)

diff --git a/tests/xfs/655 b/tests/xfs/655
index a4162d70b321f9..9d09cc00053138 100755
--- a/tests/xfs/655
+++ b/tests/xfs/655
@@ -24,10 +24,6 @@ _require_scratch_nocheck
 _require_scratch_xfs_crc # can't detect minor corruption w/o crc
 _require_xfs_io_command healthmon
 
-# Disable the scratch rt device to avoid test failures relating to the rt
-# bitmap consuming all the free space in our small data device.
-unset SCRATCH_RTDEV
-
 echo "Format and mount"
 _scratch_mkfs -d agcount=1 | _filter_mkfs 2> $tmp.mkfs >> $seqres.full
 . $tmp.mkfs
diff --git a/tests/xfs/656 b/tests/xfs/656
index df91bbdacea222..5d2d2e55c3d21c 100755
--- a/tests/xfs/656
+++ b/tests/xfs/656
@@ -40,10 +40,6 @@ filter_healer_errors() {
 		uniq
 }
 
-# Disable the scratch rt device to avoid test failures relating to the rt
-# bitmap consuming all the free space in our small data device.
-unset SCRATCH_RTDEV
-
 echo "Format and mount"
 _scratch_mkfs > $seqres.full 2>&1
 _dmerror_init no_log

  reply	other threads:[~2026-07-02  3:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  3:55 [PATCH 1/2] xfs/656: rearrange directio pread/pwrite for zoned filesystems Darrick J. Wong
2026-07-02  3:57 ` Darrick J. Wong [this message]
2026-07-02 10:36   ` [PATCH 2/2] xfs/65[56]: don't unset SCRATCH_RTDEV here Christoph Hellwig
2026-07-02 15:24     ` Darrick J. Wong
2026-07-02 10:35 ` [PATCH 1/2] xfs/656: rearrange directio pread/pwrite for zoned filesystems Christoph Hellwig
2026-07-02 15:23   ` Darrick J. Wong
2026-07-03  2:21   ` Yao Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260702035759.GB9381@frogsfrogsfrogs \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox