From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@kernel.org, fstests@vger.kernel.org,
linux-xfs@vger.kernel.org, Yao Sang <sangyao@kylinos.cn>
Subject: Re: [PATCH 2/2] xfs/65[56]: don't unset SCRATCH_RTDEV here
Date: Thu, 2 Jul 2026 08:24:07 -0700 [thread overview]
Message-ID: <20260702152407.GE9381@frogsfrogsfrogs> (raw)
In-Reply-To: <20260702103633.GC6816@lst.de>
On Thu, Jul 02, 2026 at 12:36:33PM +0200, Christoph Hellwig wrote:
> On Wed, Jul 01, 2026 at 08:57:59PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Both of these tests claim that they have to unset SCRATCH_RTDEV to avoid
> > formatting failures due to the rt bitmap consuming all the space in the
> > "small" data device. However, the format doesn't constrain the size of
> > the data device, so the justification doesn't apply. Remove the whole
> > thing.
>
> Looks good, but as-is clashes with my
> "formalize and fix disabling the RT subvolume" patch. It might make
> sense to take these two patches first, and then modified version
> of
>
> "formalize and fix disabling the RT subvolume"
>
> and
>
> "common: skip data write EIO survival tests on fatal configs"
>
> on top of that.
Whatever order's most convenient for you is 100% ok with me.
That said, yes, let's remove the braindamage from xfs/65[56] first.
--D
next prev parent reply other threads:[~2026-07-02 15:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 3:55 [PATCH 1/2] xfs/656: rearrange directio pread/pwrite for zoned filesystems Darrick J. Wong
2026-07-02 3:57 ` [PATCH 2/2] xfs/65[56]: don't unset SCRATCH_RTDEV here Darrick J. Wong
2026-07-02 10:36 ` Christoph Hellwig
2026-07-02 15:24 ` Darrick J. Wong [this message]
2026-07-02 10:35 ` [PATCH 1/2] xfs/656: rearrange directio pread/pwrite for zoned filesystems Christoph Hellwig
2026-07-02 15:23 ` Darrick J. Wong
2026-07-03 2:21 ` Yao Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702152407.GE9381@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sangyao@kylinos.cn \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox