* [RFC PATCH] libfrog: make cmn_err() emit each message atomically to avoid torn output
@ 2026-07-15 17:28 Avinesh Kumar
2026-07-15 19:09 ` Darrick J. Wong
0 siblings, 1 reply; 7+ messages in thread
From: Avinesh Kumar @ 2026-07-15 17:28 UTC (permalink / raw)
To: linux-xfs; +Cc: fstests, djwong, cem
From: Avinesh Kumar <avinesh.kumar@suse.com>
fstests xfs/033 fails sporadically with a spurious blank line in the
xfs_repair output:
- output mismatch (see /opt/xfstests/results//xfs/033.out.bad)
--- tests/xfs/033.out 2026-06-24 15:52:51.000000000 -0400
+++ /opt/xfstests/results//xfs/033.out.bad 2026-07-14 18:54:46.582495041 -0400
@@ -103,6 +103,7 @@
Phase 3 - for each AG...
- scan and clear agi unlinked lists...
- process known inodes and perform inode discovery...
+
bad magic number 0xffff on inode INO
bad version number 0xffffffff on inode INO
inode identifier 18446744073709551615 mismatch on inode INO
Root cause is in cmn_err() (libfrog/util.c), which emits a message
and its newline as two separate writes to unbuffered stderr.
xfs_repair's threads all share stderr. If one is preempted between the
two writes, another thread's line lands in between:
(snips from `cat -A 033.raw`) -
Phase 3 - for each AG...$
- scan and clear agi unlinked lists...$
- process known inodes and perform inode discovery...$
Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000 - agno = 0$
$
bad CRC for inode 128$
bad magic number 0x0 on inode 128$
which should be like -
Phase 3 - for each AG...$
- scan and clear agi unlinked lists...$
- process known inodes and perform inode discovery...$
Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000$
- agno = 0$
bad CRC for inode 130$
bad magic number 0x0 on inode 130$
_filter_repair() strips the noise line it glued onto but not the lone
newline, which then fails the golden diff.
Make the two writes atomic.
Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
Hi, please give feedback if this should be fixed in a different way.
Thanks!
libfrog/util.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libfrog/util.c b/libfrog/util.c
index 5bae5bab..3b6df917 100644
--- a/libfrog/util.c
+++ b/libfrog/util.c
@@ -116,8 +116,10 @@ cmn_err(int level, char *fmt, ...)
va_list ap;
va_start(ap, fmt);
+ flockfile(stderr);
vfprintf(stderr, fmt, ap);
fputs("\n", stderr);
+ funlockfile(stderr);
va_end(ap);
}
--
2.55.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RFC PATCH] libfrog: make cmn_err() emit each message atomically to avoid torn output
2026-07-15 17:28 [RFC PATCH] libfrog: make cmn_err() emit each message atomically to avoid torn output Avinesh Kumar
@ 2026-07-15 19:09 ` Darrick J. Wong
2026-07-16 7:44 ` Avinesh Kumar
0 siblings, 1 reply; 7+ messages in thread
From: Darrick J. Wong @ 2026-07-15 19:09 UTC (permalink / raw)
To: Avinesh Kumar; +Cc: linux-xfs, fstests, cem
On Wed, Jul 15, 2026 at 07:28:21PM +0200, Avinesh Kumar wrote:
> From: Avinesh Kumar <avinesh.kumar@suse.com>
>
> fstests xfs/033 fails sporadically with a spurious blank line in the
> xfs_repair output:
>
> - output mismatch (see /opt/xfstests/results//xfs/033.out.bad)
> --- tests/xfs/033.out 2026-06-24 15:52:51.000000000 -0400
> +++ /opt/xfstests/results//xfs/033.out.bad 2026-07-14 18:54:46.582495041 -0400
> @@ -103,6 +103,7 @@
> Phase 3 - for each AG...
> - scan and clear agi unlinked lists...
> - process known inodes and perform inode discovery...
> +
> bad magic number 0xffff on inode INO
> bad version number 0xffffffff on inode INO
> inode identifier 18446744073709551615 mismatch on inode INO
>
> Root cause is in cmn_err() (libfrog/util.c), which emits a message
> and its newline as two separate writes to unbuffered stderr.
> xfs_repair's threads all share stderr. If one is preempted between the
> two writes, another thread's line lands in between:
>
> (snips from `cat -A 033.raw`) -
> Phase 3 - for each AG...$
> - scan and clear agi unlinked lists...$
> - process known inodes and perform inode discovery...$
> Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000 - agno = 0$
> $
> bad CRC for inode 128$
> bad magic number 0x0 on inode 128$
>
> which should be like -
>
> Phase 3 - for each AG...$
> - scan and clear agi unlinked lists...$
> - process known inodes and perform inode discovery...$
> Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000$
> - agno = 0$
> bad CRC for inode 130$
> bad magic number 0x0 on inode 130$
>
> _filter_repair() strips the noise line it glued onto but not the lone
> newline, which then fails the golden diff.
>
> Make the two writes atomic.
>
> Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
> ---
>
> Hi, please give feedback if this should be fixed in a different way.
> Thanks!
>
> libfrog/util.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libfrog/util.c b/libfrog/util.c
> index 5bae5bab..3b6df917 100644
> --- a/libfrog/util.c
> +++ b/libfrog/util.c
> @@ -116,8 +116,10 @@ cmn_err(int level, char *fmt, ...)
> va_list ap;
>
> va_start(ap, fmt);
> + flockfile(stderr);
> vfprintf(stderr, fmt, ap);
> fputs("\n", stderr);
> + funlockfile(stderr);
I think do_error() in xfs_repair.c is going to need the same treatment
but otherwise this chunk looks ok to me.
--D
> va_end(ap);
> }
>
> --
> 2.55.0
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH] libfrog: make cmn_err() emit each message atomically to avoid torn output
2026-07-15 19:09 ` Darrick J. Wong
@ 2026-07-16 7:44 ` Avinesh Kumar
2026-07-16 15:13 ` Darrick J. Wong
0 siblings, 1 reply; 7+ messages in thread
From: Avinesh Kumar @ 2026-07-16 7:44 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-xfs, fstests, cem
Hello Darrick,
On 7/15/26 9:09 PM, Darrick J. Wong wrote:
> On Wed, Jul 15, 2026 at 07:28:21PM +0200, Avinesh Kumar wrote:
>> From: Avinesh Kumar <avinesh.kumar@suse.com>
>>
>> fstests xfs/033 fails sporadically with a spurious blank line in the
>> xfs_repair output:
>>
>> - output mismatch (see /opt/xfstests/results//xfs/033.out.bad)
>> --- tests/xfs/033.out 2026-06-24 15:52:51.000000000 -0400
>> +++ /opt/xfstests/results//xfs/033.out.bad 2026-07-14 18:54:46.582495041 -0400
>> @@ -103,6 +103,7 @@
>> Phase 3 - for each AG...
>> - scan and clear agi unlinked lists...
>> - process known inodes and perform inode discovery...
>> +
>> bad magic number 0xffff on inode INO
>> bad version number 0xffffffff on inode INO
>> inode identifier 18446744073709551615 mismatch on inode INO
>>
>> Root cause is in cmn_err() (libfrog/util.c), which emits a message
>> and its newline as two separate writes to unbuffered stderr.
>> xfs_repair's threads all share stderr. If one is preempted between the
>> two writes, another thread's line lands in between:
>>
>> (snips from `cat -A 033.raw`) -
>> Phase 3 - for each AG...$
>> - scan and clear agi unlinked lists...$
>> - process known inodes and perform inode discovery...$
>> Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000 - agno = 0$
>> $
>> bad CRC for inode 128$
>> bad magic number 0x0 on inode 128$
>>
>> which should be like -
>>
>> Phase 3 - for each AG...$
>> - scan and clear agi unlinked lists...$
>> - process known inodes and perform inode discovery...$
>> Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000$
>> - agno = 0$
>> bad CRC for inode 130$
>> bad magic number 0x0 on inode 130$
>>
>> _filter_repair() strips the noise line it glued onto but not the lone
>> newline, which then fails the golden diff.
>>
>> Make the two writes atomic.
>>
>> Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
>> ---
>>
>> Hi, please give feedback if this should be fixed in a different way.
>> Thanks!
>>
>> libfrog/util.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/libfrog/util.c b/libfrog/util.c
>> index 5bae5bab..3b6df917 100644
>> --- a/libfrog/util.c
>> +++ b/libfrog/util.c
>> @@ -116,8 +116,10 @@ cmn_err(int level, char *fmt, ...)
>> va_list ap;
>>
>> va_start(ap, fmt);
>> + flockfile(stderr);
>> vfprintf(stderr, fmt, ap);
>> fputs("\n", stderr);
>> + funlockfile(stderr);
>
> I think do_error() in xfs_repair.c is going to need the same treatment
> but otherwise this chunk looks ok to me.
>
Thanks for the review. I can send a follow up patch for do_error(),
or do you want these to go in the same patch?
Regards,
Avinesh
> --D
>
>> va_end(ap);
>> }
>>
>> --
>> 2.55.0
>>
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFC PATCH] libfrog: make cmn_err() emit each message atomically to avoid torn output
2026-07-16 7:44 ` Avinesh Kumar
@ 2026-07-16 15:13 ` Darrick J. Wong
2026-07-16 19:45 ` [PATCH v2] " Avinesh Kumar
0 siblings, 1 reply; 7+ messages in thread
From: Darrick J. Wong @ 2026-07-16 15:13 UTC (permalink / raw)
To: Avinesh Kumar; +Cc: linux-xfs, fstests, cem
On Thu, Jul 16, 2026 at 09:44:28AM +0200, Avinesh Kumar wrote:
> Hello Darrick,
>
>
> On 7/15/26 9:09 PM, Darrick J. Wong wrote:
> > On Wed, Jul 15, 2026 at 07:28:21PM +0200, Avinesh Kumar wrote:
> > > From: Avinesh Kumar <avinesh.kumar@suse.com>
> > >
> > > fstests xfs/033 fails sporadically with a spurious blank line in the
> > > xfs_repair output:
> > >
> > > - output mismatch (see /opt/xfstests/results//xfs/033.out.bad)
> > > --- tests/xfs/033.out 2026-06-24 15:52:51.000000000 -0400
> > > +++ /opt/xfstests/results//xfs/033.out.bad 2026-07-14 18:54:46.582495041 -0400
> > > @@ -103,6 +103,7 @@
> > > Phase 3 - for each AG...
> > > - scan and clear agi unlinked lists...
> > > - process known inodes and perform inode discovery...
> > > +
> > > bad magic number 0xffff on inode INO
> > > bad version number 0xffffffff on inode INO
> > > inode identifier 18446744073709551615 mismatch on inode INO
> > >
> > > Root cause is in cmn_err() (libfrog/util.c), which emits a message
> > > and its newline as two separate writes to unbuffered stderr.
> > > xfs_repair's threads all share stderr. If one is preempted between the
> > > two writes, another thread's line lands in between:
> > >
> > > (snips from `cat -A 033.raw`) -
> > > Phase 3 - for each AG...$
> > > - scan and clear agi unlinked lists...$
> > > - process known inodes and perform inode discovery...$
> > > Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000 - agno = 0$
> > > $
> > > bad CRC for inode 128$
> > > bad magic number 0x0 on inode 128$
> > >
> > > which should be like -
> > >
> > > Phase 3 - for each AG...$
> > > - scan and clear agi unlinked lists...$
> > > - process known inodes and perform inode discovery...$
> > > Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000$
> > > - agno = 0$
> > > bad CRC for inode 130$
> > > bad magic number 0x0 on inode 130$
> > >
> > > _filter_repair() strips the noise line it glued onto but not the lone
> > > newline, which then fails the golden diff.
> > >
> > > Make the two writes atomic.
> > >
> > > Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
> > > ---
> > >
> > > Hi, please give feedback if this should be fixed in a different way.
> > > Thanks!
> > >
> > > libfrog/util.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/libfrog/util.c b/libfrog/util.c
> > > index 5bae5bab..3b6df917 100644
> > > --- a/libfrog/util.c
> > > +++ b/libfrog/util.c
> > > @@ -116,8 +116,10 @@ cmn_err(int level, char *fmt, ...)
> > > va_list ap;
> > > va_start(ap, fmt);
> > > + flockfile(stderr);
> > > vfprintf(stderr, fmt, ap);
> > > fputs("\n", stderr);
> > > + funlockfile(stderr);
> >
> > I think do_error() in xfs_repair.c is going to need the same treatment
> > but otherwise this chunk looks ok to me.
> >
> Thanks for the review. I can send a follow up patch for do_error(),
> or do you want these to go in the same patch?
They probably ought to be in the same patch.
--D
> Regards,
> Avinesh
>
> > --D
> >
> > > va_end(ap);
> > > }
> > > --
> > > 2.55.0
> > >
> > >
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] libfrog: make cmn_err() emit each message atomically to avoid torn output
2026-07-16 15:13 ` Darrick J. Wong
@ 2026-07-16 19:45 ` Avinesh Kumar
2026-07-16 19:59 ` Darrick J. Wong
2026-07-20 12:22 ` Carlos Maiolino
0 siblings, 2 replies; 7+ messages in thread
From: Avinesh Kumar @ 2026-07-16 19:45 UTC (permalink / raw)
To: djwong; +Cc: cem, fstests, linux-xfs
From: Avinesh Kumar <avinesh.kumar@suse.com>
fstests xfs/033 fails sporadically with a spurious blank line in the
xfs_repair output:
- output mismatch (see /opt/xfstests/results//xfs/033.out.bad)
--- tests/xfs/033.out 2026-06-24 15:52:51.000000000 -0400
+++ /opt/xfstests/results//xfs/033.out.bad 2026-07-14 18:54:46.582495041 -0400
@@ -103,6 +103,7 @@
Phase 3 - for each AG...
- scan and clear agi unlinked lists...
- process known inodes and perform inode discovery...
+
bad magic number 0xffff on inode INO
bad version number 0xffffffff on inode INO
inode identifier 18446744073709551615 mismatch on inode INO
Root cause is in cmn_err() (libfrog/util.c), which emits a message
and its newline as two separate writes to unbuffered stderr.
xfs_repair's threads all share stderr. If one is preempted between the
two writes, another thread's line lands in between:
(snips from `cat -A 033.raw`) -
Phase 3 - for each AG...$
- scan and clear agi unlinked lists...$
- process known inodes and perform inode discovery...$
Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000 - agno = 0$
$
bad CRC for inode 128$
bad magic number 0x0 on inode 128$
which should be like -
Phase 3 - for each AG...$
- scan and clear agi unlinked lists...$
- process known inodes and perform inode discovery...$
Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000$
- agno = 0$
bad CRC for inode 130$
bad magic number 0x0 on inode 130$
_filter_repair() strips the noise line it glued onto but not the lone
newline, which then fails the golden diff.
Make the two writes atomic.
do_error() in xfs_repair.c also has same issue, fix that too.
Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
---
v2: fix the do_error() in xfs_repair.c too.
libfrog/util.c | 2 ++
repair/xfs_repair.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/libfrog/util.c b/libfrog/util.c
index 5bae5bab..3b6df917 100644
--- a/libfrog/util.c
+++ b/libfrog/util.c
@@ -116,8 +116,10 @@ cmn_err(int level, char *fmt, ...)
va_list ap;
va_start(ap, fmt);
+ flockfile(stderr);
vfprintf(stderr, fmt, ap);
fputs("\n", stderr);
+ funlockfile(stderr);
va_end(ap);
}
diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
index 6b97a806..dd758ebc 100644
--- a/repair/xfs_repair.c
+++ b/repair/xfs_repair.c
@@ -458,10 +458,12 @@ do_error(char const *msg, ...)
{
va_list args;
+ flockfile(stderr);
fprintf(stderr, _("\nfatal error -- "));
va_start(args, msg);
vfprintf(stderr, msg, args);
+ funlockfile(stderr);
if (dumpcore)
abort();
exit(1);
--
2.55.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] libfrog: make cmn_err() emit each message atomically to avoid torn output
2026-07-16 19:45 ` [PATCH v2] " Avinesh Kumar
@ 2026-07-16 19:59 ` Darrick J. Wong
2026-07-20 12:22 ` Carlos Maiolino
1 sibling, 0 replies; 7+ messages in thread
From: Darrick J. Wong @ 2026-07-16 19:59 UTC (permalink / raw)
To: Avinesh Kumar; +Cc: cem, fstests, linux-xfs
On Thu, Jul 16, 2026 at 09:45:49PM +0200, Avinesh Kumar wrote:
> From: Avinesh Kumar <avinesh.kumar@suse.com>
>
> fstests xfs/033 fails sporadically with a spurious blank line in the
> xfs_repair output:
>
> - output mismatch (see /opt/xfstests/results//xfs/033.out.bad)
> --- tests/xfs/033.out 2026-06-24 15:52:51.000000000 -0400
> +++ /opt/xfstests/results//xfs/033.out.bad 2026-07-14 18:54:46.582495041 -0400
> @@ -103,6 +103,7 @@
> Phase 3 - for each AG...
> - scan and clear agi unlinked lists...
> - process known inodes and perform inode discovery...
> +
> bad magic number 0xffff on inode INO
> bad version number 0xffffffff on inode INO
> inode identifier 18446744073709551615 mismatch on inode INO
>
> Root cause is in cmn_err() (libfrog/util.c), which emits a message
> and its newline as two separate writes to unbuffered stderr.
> xfs_repair's threads all share stderr. If one is preempted between the
> two writes, another thread's line lands in between:
>
> (snips from `cat -A 033.raw`) -
> Phase 3 - for each AG...$
> - scan and clear agi unlinked lists...$
> - process known inodes and perform inode discovery...$
> Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000 - agno = 0$
> $
> bad CRC for inode 128$
> bad magic number 0x0 on inode 128$
>
> which should be like -
>
> Phase 3 - for each AG...$
> - scan and clear agi unlinked lists...$
> - process known inodes and perform inode discovery...$
> Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000$
> - agno = 0$
> bad CRC for inode 130$
> bad magic number 0x0 on inode 130$
>
> _filter_repair() strips the noise line it glued onto but not the lone
> newline, which then fails the golden diff.
>
> Make the two writes atomic.
>
> do_error() in xfs_repair.c also has same issue, fix that too.
>
> Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
Looks good to me, hopefully this will cut down on the random xfs_repair
errors in fstests.
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> v2: fix the do_error() in xfs_repair.c too.
>
> libfrog/util.c | 2 ++
> repair/xfs_repair.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/libfrog/util.c b/libfrog/util.c
> index 5bae5bab..3b6df917 100644
> --- a/libfrog/util.c
> +++ b/libfrog/util.c
> @@ -116,8 +116,10 @@ cmn_err(int level, char *fmt, ...)
> va_list ap;
>
> va_start(ap, fmt);
> + flockfile(stderr);
> vfprintf(stderr, fmt, ap);
> fputs("\n", stderr);
> + funlockfile(stderr);
> va_end(ap);
> }
>
> diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
> index 6b97a806..dd758ebc 100644
> --- a/repair/xfs_repair.c
> +++ b/repair/xfs_repair.c
> @@ -458,10 +458,12 @@ do_error(char const *msg, ...)
> {
> va_list args;
>
> + flockfile(stderr);
> fprintf(stderr, _("\nfatal error -- "));
>
> va_start(args, msg);
> vfprintf(stderr, msg, args);
> + funlockfile(stderr);
> if (dumpcore)
> abort();
> exit(1);
> --
> 2.55.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] libfrog: make cmn_err() emit each message atomically to avoid torn output
2026-07-16 19:45 ` [PATCH v2] " Avinesh Kumar
2026-07-16 19:59 ` Darrick J. Wong
@ 2026-07-20 12:22 ` Carlos Maiolino
1 sibling, 0 replies; 7+ messages in thread
From: Carlos Maiolino @ 2026-07-20 12:22 UTC (permalink / raw)
To: Avinesh Kumar; +Cc: djwong, fstests, linux-xfs, aalbersh
On Thu, Jul 16, 2026 at 09:45:49PM +0200, Avinesh Kumar wrote:
> From: Avinesh Kumar <avinesh.kumar@suse.com>
>
Adding Andrey to the thread as he's maintaining xfsprogs.
> fstests xfs/033 fails sporadically with a spurious blank line in the
> xfs_repair output:
>
> - output mismatch (see /opt/xfstests/results//xfs/033.out.bad)
> --- tests/xfs/033.out 2026-06-24 15:52:51.000000000 -0400
> +++ /opt/xfstests/results//xfs/033.out.bad 2026-07-14 18:54:46.582495041 -0400
> @@ -103,6 +103,7 @@
> Phase 3 - for each AG...
> - scan and clear agi unlinked lists...
> - process known inodes and perform inode discovery...
> +
> bad magic number 0xffff on inode INO
> bad version number 0xffffffff on inode INO
> inode identifier 18446744073709551615 mismatch on inode INO
>
> Root cause is in cmn_err() (libfrog/util.c), which emits a message
> and its newline as two separate writes to unbuffered stderr.
> xfs_repair's threads all share stderr. If one is preempted between the
> two writes, another thread's line lands in between:
>
> (snips from `cat -A 033.raw`) -
> Phase 3 - for each AG...$
> - scan and clear agi unlinked lists...$
> - process known inodes and perform inode discovery...$
> Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000 - agno = 0$
> $
> bad CRC for inode 128$
> bad magic number 0x0 on inode 128$
>
> which should be like -
>
> Phase 3 - for each AG...$
> - scan and clear agi unlinked lists...$
> - process known inodes and perform inode discovery...$
> Metadata corruption detected at 0x445dd3, xfs_inode block 0x80/0x4000$
> - agno = 0$
> bad CRC for inode 130$
> bad magic number 0x0 on inode 130$
>
> _filter_repair() strips the noise line it glued onto but not the lone
> newline, which then fails the golden diff.
>
> Make the two writes atomic.
>
> do_error() in xfs_repair.c also has same issue, fix that too.
>
> Signed-off-by: Avinesh Kumar <avinesh.kumar@suse.com>
> ---
> v2: fix the do_error() in xfs_repair.c too.
>
> libfrog/util.c | 2 ++
> repair/xfs_repair.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/libfrog/util.c b/libfrog/util.c
> index 5bae5bab..3b6df917 100644
> --- a/libfrog/util.c
> +++ b/libfrog/util.c
> @@ -116,8 +116,10 @@ cmn_err(int level, char *fmt, ...)
> va_list ap;
>
> va_start(ap, fmt);
> + flockfile(stderr);
> vfprintf(stderr, fmt, ap);
> fputs("\n", stderr);
> + funlockfile(stderr);
> va_end(ap);
> }
>
> diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
> index 6b97a806..dd758ebc 100644
> --- a/repair/xfs_repair.c
> +++ b/repair/xfs_repair.c
> @@ -458,10 +458,12 @@ do_error(char const *msg, ...)
> {
> va_list args;
>
> + flockfile(stderr);
> fprintf(stderr, _("\nfatal error -- "));
>
> va_start(args, msg);
> vfprintf(stderr, msg, args);
> + funlockfile(stderr);
> if (dumpcore)
> abort();
> exit(1);
> --
> 2.55.0
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-07-20 12:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-15 17:28 [RFC PATCH] libfrog: make cmn_err() emit each message atomically to avoid torn output Avinesh Kumar
2026-07-15 19:09 ` Darrick J. Wong
2026-07-16 7:44 ` Avinesh Kumar
2026-07-16 15:13 ` Darrick J. Wong
2026-07-16 19:45 ` [PATCH v2] " Avinesh Kumar
2026-07-16 19:59 ` Darrick J. Wong
2026-07-20 12:22 ` Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox