[PATCH] xfs/507: use mount -t xfs

[PATCH] xfs/507: use mount -t xfs

[Christoph Hellwig]

Sometimes mount wants to try every other file system but XFS when
mounting the loop image, making this test fail.  Force mounting as XFS
to make it reliably pass.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 tests/xfs/507 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/507 b/tests/xfs/507
index e1450f4f8f94..a9eb8646680b 100755
--- a/tests/xfs/507
+++ b/tests/xfs/507
@@ -86,7 +86,7 @@ loop_dev=$(_create_loop_device $loop_file)
 
 _mkfs_dev -d cowextsize=$MAXEXTLEN -l size=256m $loop_dev >> $seqres.full
 mkdir $loop_mount
-_mount $loop_dev $loop_mount
+_mount -t xfs $loop_dev $loop_mount
 
 echo "Create crazy huge file"
 huge_file="$loop_mount/a"
-- 
2.53.0

Re: [PATCH] xfs/507: use mount -t xfs

[Darrick J. Wong]

On Wed, Jul 29, 2026 at 02:59:55PM +0200, Christoph Hellwig wrote:
> Sometimes mount wants to try every other file system but XFS when
> mounting the loop image, making this test fail.  Force mounting as XFS
> to make it reliably pass.

Weird.  Do you know why it does that?  Did the kernel really skip xfs or
were the sb verifiers simply running in quiet mode?

--D

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/xfs/507 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/507 b/tests/xfs/507
> index e1450f4f8f94..a9eb8646680b 100755
> --- a/tests/xfs/507
> +++ b/tests/xfs/507
> @@ -86,7 +86,7 @@ loop_dev=$(_create_loop_device $loop_file)
>  
>  _mkfs_dev -d cowextsize=$MAXEXTLEN -l size=256m $loop_dev >> $seqres.full
>  mkdir $loop_mount
> -_mount $loop_dev $loop_mount
> +_mount -t xfs $loop_dev $loop_mount
>  
>  echo "Create crazy huge file"
>  huge_file="$loop_mount/a"
> -- 
> 2.53.0
> 
> 

Re: [PATCH] xfs/507: use mount -t xfs

[Christoph Hellwig]

On Wed, Jul 29, 2026 at 08:46:50AM -0700, Darrick J. Wong wrote:
> On Wed, Jul 29, 2026 at 02:59:55PM +0200, Christoph Hellwig wrote:
> > Sometimes mount wants to try every other file system but XFS when
> > mounting the loop image, making this test fail.  Force mounting as XFS
> > to make it reliably pass.
> 
> Weird.  Do you know why it does that?  Did the kernel really skip xfs or
> were the sb verifiers simply running in quiet mode?

Not really.  I also happens in weird patches, I can reproduce it a few
times in a row, but just when I get ready to investigate the problem,
it goes away.