[PATCH] libxfs: report device open errors during topology probing

[Hans Holmberg <hans.holmberg@wdc.com>]

mkfs probes the device topology before libxfs_init opens the target.
If blkid cannot open the device, blkid_new_probe_from_filename returns
NULL and leaves the topology sector sizes initialized to zero.  This
causes mkfs to report the misleading error "illegal sector size 0".

Report the underlying open error immediately so that permission
failures are diagnosed correctly. For example:

cannot probe device topology for device /dev/nvme1n1: Permission denied

Signed-off-by: Hans Holmberg <hans.holmberg@wdc.com>
---
 libxfs/topology.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/libxfs/topology.c b/libxfs/topology.c
index dc2aaa17..5571c9d8 100644
--- a/libxfs/topology.c
+++ b/libxfs/topology.c
@@ -230,8 +230,12 @@ blkid_get_topology(
 	blkid_probe pr;
 
 	pr = blkid_new_probe_from_filename(device);
-	if (!pr)
-		return;
+	if (!pr) {
+		fprintf(stderr,
+			_("cannot probe device topology for device %s: %s\n"),
+			device, strerror(errno));
+		exit(EXIT_FAILURE);
+	}
 
 	tp = blkid_probe_get_topology(pr);
 	if (!tp)
-- 
2.53.0