From: Christoph Hellwig <hch@lst.de>
To: Hans Holmberg <hans.holmberg@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, aalbersh@kernel.org, cem@kernel.org,
djwong@kernel.org
Subject: Re: [PATCH] libxfs: report device open errors during topology probing
Date: Wed, 2 Sep 2026 07:59:54 +0200 [thread overview]
Message-ID: <20260902055954.GA24431@lst.de> (raw)
In-Reply-To: <32e910c2-28b1-4df5-99aa-8bf13801ca1e@wdc.com>
On Tue, Sep 01, 2026 at 10:46:27AM +0200, Hans Holmberg wrote:
> > I wonder if there are any valid failures from blkid_new_probe_from_filename
> > where we'd want to continue? Probably not as it doesn't really have an
> > obvious failure path, but so far we continue here. So the print is useful
> > for sure, but I wonder if failing here might cause regressions in some
> > really odd use case (containers without sysfs? Although we'd run into
> > trouble with that quickly in other places).
>
>
> Yeah, it might be safer to just print the warning, and that would solve
> my problem (no instructive error message),
>
> On the other hand it's nice to fail early - but not if it causes regressions
> of course.
Yeah, failing early is nice, but I'm a bit fearful we might break
existing (but really weird setups).
next prev parent reply other threads:[~2026-09-02 5:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 11:28 [PATCH] libxfs: report device open errors during topology probing Hans Holmberg
2026-08-31 7:10 ` Christoph Hellwig
2026-09-01 8:46 ` Hans Holmberg
2026-09-02 5:59 ` Christoph Hellwig [this message]
2026-09-02 16:20 ` Darrick J. Wong
2026-09-03 5:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902055954.GA24431@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hans.holmberg@wdc.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox