From: cem@kernel.org
To: cem@kernel.org
Cc: djwong@kernel.org, hch@lst.de, sandeen@sandeen.net,
linux-xfs@vger.kernel.org
Subject: [PATCH v3 3/3] xfs: make xfs_iomap_write_direct() report an error to xfs_trans_cancel
Date: Thu, 17 Sep 2026 12:35:48 +0200 [thread overview]
Message-ID: <20260917103633.14703-4-cem@kernel.org> (raw)
In-Reply-To: <20260917103633.14703-1-cem@kernel.org>
From: Carlos Maiolino <cem@kernel.org>
I've been in the situation a few times where the transaction got
cancelled by some reason. Most of time because bmapi_write failed and I
start a guessing game trying to understand why.
So if xfs_iomap_write_direct fails and it causes the transaction to be
cancelled, send the error to xfs_trans_cancel so the error gets logged
into the kernel log buffer.
Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
---
fs/xfs/xfs_iomap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index 7c6238fed61e..4906a4828d11 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -358,7 +358,7 @@ xfs_iomap_write_direct(
return error;
out_trans_cancel:
- xfs_trans_cancel(tp);
+ xfs_trans_cancel_error(tp, error);
goto out_unlock;
}
--
2.55.0
next prev parent reply other threads:[~2026-09-17 10:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 10:35 [PATCH v3 0/3] Enable xfs error reporting to print out error codes cem
2026-09-17 10:35 ` [PATCH v3 1/3] xfs: add xfs_error_report the ability to display an error code cem
2026-09-21 3:36 ` Darrick J. Wong
2026-09-21 8:33 ` Christoph Hellwig
2026-09-17 10:35 ` [PATCH v3 2/3] xfs: enable xfs_trans_cancel() to report and " cem
2026-09-21 8:33 ` Christoph Hellwig
2026-09-23 10:49 ` Carlos Maiolino
2026-09-23 14:39 ` Christoph Hellwig
2026-09-17 10:35 ` cem [this message]
2026-09-21 8:34 ` [PATCH v3 3/3] xfs: make xfs_iomap_write_direct() report an error to xfs_trans_cancel Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917103633.14703-4-cem@kernel.org \
--to=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox