From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cem@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
djwong@kernel.org, sandeen@sandeen.net,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH v3 2/3] xfs: enable xfs_trans_cancel() to report and error code
Date: Wed, 23 Sep 2026 16:39:06 +0200 [thread overview]
Message-ID: <20260923143906.GB28435@lst.de> (raw)
In-Reply-To: <arOjRDxCUZj3FvKP@nidhogg.toxiclabs.cc>
On Wed, Sep 23, 2026 at 12:49:01PM +0200, Carlos Maiolino wrote:
> > And do away with the pointless __xfs_trans_cancel, just implement
> > xfs_trans_cancel_error in xfs_trans.c, and wrap xfs_trans_cancel around
> > it.
>
> The main reason I created __xfs_trans_cancel was to avoid a fs/xfs/*
> change of calls to xfs_trans_cancel().
And that's a good idea. But we don't need the extra
__xfs_trans_cancel vs xfs_trans_cancel_error indirection. Just rename
what is __xfs_trans_cancel in this series to xfs_trans_cancel_error,
and make xfs_trans_cancel an inline wrapper around that.
next prev parent reply other threads:[~2026-09-23 14:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 10:35 [PATCH v3 0/3] Enable xfs error reporting to print out error codes cem
2026-09-17 10:35 ` [PATCH v3 1/3] xfs: add xfs_error_report the ability to display an error code cem
2026-09-21 3:36 ` Darrick J. Wong
2026-09-21 8:33 ` Christoph Hellwig
2026-09-17 10:35 ` [PATCH v3 2/3] xfs: enable xfs_trans_cancel() to report and " cem
2026-09-21 8:33 ` Christoph Hellwig
2026-09-23 10:49 ` Carlos Maiolino
2026-09-23 14:39 ` Christoph Hellwig [this message]
2026-09-17 10:35 ` [PATCH v3 3/3] xfs: make xfs_iomap_write_direct() report an error to xfs_trans_cancel cem
2026-09-21 8:34 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923143906.GB28435@lst.de \
--to=hch@lst.de \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox