From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH 13/13] xfs/2308: test rebuilding of csum files in xfs_repair
Date: Thu, 24 Sep 2026 12:07:54 +0200 [thread overview]
Message-ID: <20260924100855.2734089-14-hch@lst.de> (raw)
In-Reply-To: <20260924100855.2734089-1-hch@lst.de>
Plus handling of corrupted csum files in the kernel as a side effect.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
tests/xfs/2308 | 47 ++++++++++++++++++++++++++++++++++++++++++++++
tests/xfs/2308.out | 4 ++++
2 files changed, 51 insertions(+)
create mode 100755 tests/xfs/2308
create mode 100644 tests/xfs/2308.out
diff --git a/tests/xfs/2308 b/tests/xfs/2308
new file mode 100755
index 000000000000..5c4f647ced7a
--- /dev/null
+++ b/tests/xfs/2308
@@ -0,0 +1,47 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0-or-later
+# Copyright (c) 2026 Christoph Hellwig.
+#
+# FS QA Test No. 2308
+#
+# Corrupt rtcsum and check that scrub and different kinds of reads catch them.
+#
+. ./common/preamble
+_begin_fstest auto quick zone datacsum scrub
+
+. ./common/filter
+. ./common/fuzzy
+
+_require_scratch_nocheck
+
+_scratch_mkfs >> $seqres.full 2>&1
+_scratch_mount
+_require_xfs_data_csum $TEST_DIR
+
+cat /bin/sh > $SCRATCH_MNT/sh
+sync $SCRATCH_MNT
+
+rg=`xfs_bmap -v $SCRATCH_MNT/sh | _filter_bmap_gno`
+rg="${rg// /}"
+
+_scratch_unmount
+
+$XFS_DB_PROG -x $SCRATCH_DEV \
+ -c "path -m /rtgroups/$rg.csum" \
+ -c 'dblock 0' \
+ -c 'write csums[0] 4266'
+
+_scratch_mount
+$XFS_SCRUB_PROG -x -a 1 $SCRATCH_MNT >> $seqres.full 2>&1
+if [ $? -eq 0 ]; then
+ _fail "scrub did not find corruption"
+fi
+
+# Test buffered I/O
+$XFS_IO_PROG -c 'pread 0 64k' $SCRATCH_MNT/sh
+
+# Test direct I/O
+$XFS_IO_PROG -d -c 'pread 0 64k' $SCRATCH_MNT/sh
+
+status=0
+exit
diff --git a/tests/xfs/2308.out b/tests/xfs/2308.out
new file mode 100644
index 000000000000..55f6a0c97264
--- /dev/null
+++ b/tests/xfs/2308.out
@@ -0,0 +1,4 @@
+QA output created by 2308
+csums[0] = 4266
+pread: Input/output error
+pread: Input/output error
--
2.53.0
next prev parent reply other threads:[~2026-09-24 10:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 10:07 xfstests support for RT data checksums Christoph Hellwig
2026-09-24 10:07 ` [PATCH 01/13] add a "datacsum" group Christoph Hellwig
2026-09-29 1:31 ` Darrick J. Wong
2026-10-05 13:17 ` Christoph Hellwig
2026-09-24 10:07 ` [PATCH 02/13] common: add a SCRATCH_MKFS_OPTIONS variable Christoph Hellwig
2026-09-29 1:32 ` Darrick J. Wong
2026-10-05 13:18 ` Christoph Hellwig
2026-09-24 10:07 ` [PATCH 03/13] xfs: add a XFS_VERIFY_FILE_DATA variable Christoph Hellwig
2026-09-29 1:34 ` Darrick J. Wong
2026-09-24 10:07 ` [PATCH 04/13] xfs/206: filter out csum information from mkfs output Christoph Hellwig
2026-09-29 1:34 ` Darrick J. Wong
2026-09-24 10:07 ` [PATCH 05/13] xfs: add a _require_xfs_data_csum helper Christoph Hellwig
2026-09-29 1:38 ` Darrick J. Wong
2026-10-05 13:20 ` Christoph Hellwig
2026-10-05 14:48 ` Darrick J. Wong
2026-10-05 14:55 ` Christoph Hellwig
2026-09-24 10:07 ` [PATCH 06/13] xfs/2301: test lazy bounce buffering mode Christoph Hellwig
2026-09-29 1:42 ` Darrick J. Wong
2026-10-05 13:21 ` Christoph Hellwig
2026-09-24 10:07 ` [PATCH 07/13] xfs/2302: add a basic data checksum test Christoph Hellwig
2026-09-29 1:48 ` Darrick J. Wong
2026-10-05 13:22 ` Christoph Hellwig
2026-09-24 10:07 ` [PATCH 08/13] xfs/2303: test that data checksums detect data misplacement Christoph Hellwig
2026-09-29 1:54 ` Darrick J. Wong
2026-10-05 13:23 ` Christoph Hellwig
2026-09-24 10:07 ` [PATCH 09/13] xfs/2304: version of generic/388 that run xfs_scrub -x for each iteration Christoph Hellwig
2026-09-29 1:56 ` Darrick J. Wong
2026-10-05 13:25 ` Christoph Hellwig
2026-10-05 14:51 ` Darrick J. Wong
2026-10-05 14:56 ` Christoph Hellwig
2026-10-05 15:20 ` Darrick J. Wong
2026-10-07 13:42 ` Christoph Hellwig
2026-10-07 15:19 ` Darrick J. Wong
2026-09-24 10:07 ` [PATCH 10/13] xfs/2305: version of generic/475 " Christoph Hellwig
2026-09-29 1:57 ` Darrick J. Wong
2026-10-05 13:25 ` Christoph Hellwig
2026-09-24 10:07 ` [PATCH 11/13] xfs/2306: test mkfs input validation for RT data csum options Christoph Hellwig
2026-09-29 1:59 ` Darrick J. Wong
2026-10-05 13:26 ` Christoph Hellwig
2026-09-24 10:07 ` [PATCH 12/13] xfs/2307: test checksum handling using corrupted checksums Christoph Hellwig
2026-09-29 2:05 ` Darrick J. Wong
2026-10-05 13:27 ` Christoph Hellwig
2026-09-24 10:07 ` Christoph Hellwig [this message]
2026-09-29 2:03 ` [PATCH 13/13] xfs/2308: test rebuilding of csum files in xfs_repair Darrick J. Wong
2026-10-05 13:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924100855.2734089-14-hch@lst.de \
--to=hch@lst.de \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox