Re: [PATCH 09/13] xfs/2304: version of generic/388 that run xfs_scrub -x for each iteration

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Oct 05, 2026 at 04:56:15PM +0200, Christoph Hellwig wrote:
> On Mon, Oct 05, 2026 at 07:51:23AM -0700, Darrick J. Wong wrote:
> > I'm ok with g388 running more slowly if it'll catch data checksum bugs
> > and whatnot.  I'm a little surprised that it doesn't already run
> > _check_filesystems every loop iteration.
> 
> Maybe we should patch that in first, and then XFS_VERIFY_FILE_DATA
> magically does the right thing?

I was about to repy "Sounds like a good idea for g388 and probably g475
as well" but then I remembered something from my notes.  The two tests
run without _check_filesystems on the assumption that accidental
corruptions will multiply until either (a) the cycle_mount will fail or
(b) the post-test _check_filesystems will have a lot to complain about.
Doing the check every loop cycle reduces the number of log recoveries
that we can do in a given SOAK_DURATION by a significant amount.

What if we ran $XFS_IO_PROG -c verifymedia once per loop if
XFS_VERIFY_FILE_DATA?  That would avoid a full xfs_{repair,scrub} run
(+ extra mount cycle) but catch problems earlier.

--D