From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Carlos Maiolino <cem@kernel.org>, linux-xfs@vger.kernel.org
Subject: Re: small cleanups to help code sharing with xfsprogs
Date: Fri, 25 Sep 2026 15:52:33 -0700 [thread overview]
Message-ID: <20260925225233.GZ2705364@frogsfrogsfrogs> (raw)
In-Reply-To: <20260925151841.3385994-1-hch@lst.de>
On Fri, Sep 25, 2026 at 05:18:25PM +0200, Christoph Hellwig wrote:
> Hi all,
>
> this series has a few trivial cleanups and code moves that help
> sharing more code with xfsprogs.
Hrmm. This is a somewhat different approach than what Chris Wedgwood
did for his log port to userspace. What do the maintainers think? I'll
defer to them as to whether pushing some of the log code into
fs/xfs/libxfs is better than pushing all the log code to fs/xfs/libxlog.
The code changes look ok, so for the whole series,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
>
> Diffstat:
> libxfs/xfs_attr_item.h | 2 --
> libxfs/xfs_bmap_item.h | 2 --
> libxfs/xfs_buf_item.h | 2 --
> libxfs/xfs_defer.c | 1 -
> libxfs/xfs_exchmaps_item.h | 2 --
> libxfs/xfs_extfree_item.h | 2 --
> libxfs/xfs_inode_buf.c | 3 ---
> libxfs/xfs_inode_item.h | 2 --
> libxfs/xfs_inode_util.c | 1 -
> libxfs/xfs_refcount.c | 1 -
> libxfs/xfs_refcount_item.h | 2 --
> libxfs/xfs_rmap_item.h | 2 --
> libxfs/xfs_rtbitmap.c | 1 -
> libxfs/xfs_rtgroup.c | 1 -
> libxfs/xfs_sb.c | 1 -
> libxfs/xfs_trans.h | 2 --
> libxfs/xfs_trans_inode.c | 2 --
> xfs_platform.h | 1 +
> 18 files changed, 1 insertion(+), 29 deletions(-)
>
next prev parent reply other threads:[~2026-09-25 22:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 15:18 small cleanups to help code sharing with xfsprogs Christoph Hellwig
2026-09-25 15:18 ` [PATCH 1/4] xfs: remove various unused includes in libxfs/ Christoph Hellwig
2026-09-25 15:18 ` [PATCH 2/4] xfs: include <linux/iversion.h> in xfs_platform.h Christoph Hellwig
2026-09-25 15:18 ` [PATCH 3/4] xfs: move xfs_*_item.h to libxfs Christoph Hellwig
2026-09-25 15:18 ` [PATCH 4/4] xfs: move xfs_trans.h " Christoph Hellwig
2026-09-25 22:52 ` Darrick J. Wong [this message]
2026-09-26 6:06 ` small cleanups to help code sharing with xfsprogs Christoph Hellwig
2026-10-05 10:02 ` Carlos Maiolino
2026-10-08 13:32 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925225233.GZ2705364@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox