Re: small cleanups to help code sharing with xfsprogs

[Carlos Maiolino <cem@kernel.org>]

Back from conferences. Sorry the late reply...

On Sat, Sep 26, 2026 at 08:06:11AM +0200, Christoph Hellwig wrote:
> On Fri, Sep 25, 2026 at 03:52:33PM -0700, Darrick J. Wong wrote:
> > On Fri, Sep 25, 2026 at 05:18:25PM +0200, Christoph Hellwig wrote:
> > > Hi all,
> > > 
> > > this series has a few trivial cleanups and code moves that help
> > > sharing more code with xfsprogs.
> > 
> > Hrmm.  This is a somewhat different approach than what Chris Wedgwood
> > did for his log port to userspace.
> 
> Well, that seems to have been an AI slop dump without any further
> engagement from the LLM-herder, so I'm not sure it matters.

Indeed, I'd stay with this series, so for this series:

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> 
> But it also is a bit of a different thing.  This series tries to reduce
> the kernel/user libxfs differences, and reusing whatever we can from
> the kernel helps with that.  What we do about the log becomes relevant
> if/when we want to update that or share more.  My previously stated
> opinion is that splitting a single kernel code base into two libraries,
> which then generally are linked into the same programs again is not
> helpful.  But someone comes up with a design that actually makes it
> work painlessly I would not complain.  In the meantime I'd improve
> the maintainability of libxfs without touching the logging code at all.

Agreed.