Re: [PATCH 01/13] libxfs: use libxfs.h in xfs_platform.h

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Oct 05, 2026 at 02:56:11PM +0200, Christoph Hellwig wrote:
> xfs_platform.h duplicates a lot of the include chains and some of the
> definitions in include/libxfs.h.  Use that header from xfs_plaform.h and
> remove the duplication.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Seems fine to me to combine these, not sure why we didn't earlier...
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  libxfs/xfs_platform.h | 37 +------------------------------------
>  1 file changed, 1 insertion(+), 36 deletions(-)
> 
> diff --git a/libxfs/xfs_platform.h b/libxfs/xfs_platform.h
> index d09fb0aae00f..9aa898200da8 100644
> --- a/libxfs/xfs_platform.h
> +++ b/libxfs/xfs_platform.h
> @@ -37,33 +37,9 @@
>  #ifndef _XFS_PLATFORM_H
>  #define _XFS_PLATFORM_H
>  
> -/* CONFIG_XFS_* must be defined to 1 to work with IS_ENABLED() */
> -#define CONFIG_XFS_RT 1
> -#define CONFIG_XFS_BTREE_IN_MEM 1
> -
> -#include "libxfs_api_defs.h"
> -#include "platform_defs.h"
> -#include "xfs.h"
> -
> -#include "list.h"
> -#include "hlist.h"
> -#include "cache.h"
> -#include "bitops.h"
> -#include "kmem.h"
> -#include "libfrog/radix-tree.h"
> -#include "libfrog/bitmask.h"
> -#include "libfrog/div64.h"
> -#include "libfrog/util.h"
> -#include "atomic.h"
> -#include "spinlock.h"
> +#include "libxfs.h"
>  #include "linux-err.h"
>  
> -#include "xfs_types.h"
> -#include "xfs_arch.h"
> -
> -#include "xfs_fs.h"
> -#include "libfrog/crc32c.h"
> -
>  #include <sys/xattr.h>
>  
>  /* Zones used in libxfs allocations that aren't in shared header files */
> @@ -77,9 +53,6 @@ extern struct kmem_cache *xfs_trans_cache;
>  #define IOMAP_F_SHARED				0x04
>  #define xfs_bmbt_to_iomap(a, b, c, d, e, f)	((void) 0)
>  
> -/* CRC stuff, buffer API dependent on it */
> -#define crc32c(c,p,l)	crc32c_le((c),(unsigned char const *)(p),(l))
> -
>  /* fake up kernel's iomap, (not) used in xfs_bmap.[ch] */
>  struct iomap {
>  	unsigned long long	offset;	/* do not use */
> @@ -88,14 +61,6 @@ struct iomap {
>  
>  #define cancel_delayed_work_sync(work) do { } while(0)
>  
> -#include "xfs_cksum.h"
> -
> -/*
> - * This mirrors the kernel include for xfs_buf.h - it's implicitly included in
> - * every files via a similar include in the kernel xfs_linux.h.
> - */
> -#include "libxfs_io.h"
> -
>  /* for all the support code that uses progname in error messages */
>  extern char    *progname;
>  
> -- 
> 2.53.0
> 
>