Re: [PATCH 09/13] libxfs: return int from xfs_buf_item_init

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Oct 05, 2026 at 02:56:19PM +0200, Christoph Hellwig wrote:
> Match the kernel version.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks fine to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  libxfs/logitem.c      | 6 +++---
>  libxfs/xfs_platform.h | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/libxfs/logitem.c b/libxfs/logitem.c
> index 0bb9088db351..2e050ad92a1e 100644
> --- a/libxfs/logitem.c
> +++ b/libxfs/logitem.c
> @@ -71,7 +71,7 @@ static const struct xfs_item_ops xfs_buf_item_ops = {
>   * buffer (see xfs_buf_attach_iodone() below), then put the
>   * buf log item at the front.
>   */
> -void
> +int
>  xfs_buf_item_init(
>  	struct xfs_buf		*bp,
>  	struct xfs_mount	*mp)
> @@ -97,7 +97,7 @@ xfs_buf_item_init(
>  				"reused buf item %p for pre-logged buffer %p\n",
>  				lip, bp);
>  #endif
> -			return;
> +			return 0;
>  		}
>  	}
>  
> @@ -112,9 +112,9 @@ xfs_buf_item_init(
>  	bip->__bli_format.blf_blkno = (int64_t)xfs_buf_daddr(bp);
>  	bip->__bli_format.blf_len = (unsigned short)bp->b_length;
>  	bp->b_log_item = bip;
> +	return 0;
>  }
>  
> -
>  /*
>   * Mark bytes first through last inclusive as dirty in the buf
>   * item's bitmap.
> diff --git a/libxfs/xfs_platform.h b/libxfs/xfs_platform.h
> index 9aa898200da8..2e3d323505c5 100644
> --- a/libxfs/xfs_platform.h
> +++ b/libxfs/xfs_platform.h
> @@ -408,7 +408,7 @@ void xfs_trans_del_item(struct xfs_log_item *);
>  void xfs_inode_item_init(struct xfs_inode *, struct xfs_mount *);
>  
>  /* xfs_buf_item.c */
> -void xfs_buf_item_init(struct xfs_buf *, struct xfs_mount *);
> +int xfs_buf_item_init(struct xfs_buf *, struct xfs_mount *);
>  void xfs_buf_item_log(struct xfs_buf_log_item *, uint, uint);
>  
>  /* xfs_trans_buf.c */
> -- 
> 2.53.0
> 
>