From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 04/12] xfs: reattach dquots after changing inode ids
Date: Thu, 8 Oct 2026 10:20:04 -0700 [thread overview]
Message-ID: <20261008172004.GT2705364@frogsfrogsfrogs> (raw)
In-Reply-To: <aseFDykX3OaCKSC1@infradead.org>
On Thu, Oct 08, 2026 at 04:57:03AM -0700, Christoph Hellwig wrote:
> On Wed, Oct 07, 2026 at 10:55:52PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > LOLLM noticed that xrep_inode_ids can change the user, group, or project
> > id of any given file. When this happens, we need to detach any existing
> > incore dquot and attach the correct ones.
>
> Sashiko complains about changing the dquot while attached to the
> inode and I think it is right, or rather the issue goes even deeper.
> We should not have the dquot attached while changing these identifier
> as otherwise things will get really nasty. I'm not really sure how
> to do better here, though.
Yeah.... as Sashiko points out, the dquots might be attached to the
transaction, so dqdetaching them with a transaction held is baaaad.
The dquot detach and reattach have to get done at the end, after we've
committed all the inode updates. Will update this patch and resend it.
--D
next prev parent reply other threads:[~2026-10-08 17:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 5:55 [PATCHSET] xfs: LLM-inspired bug fixes, part 21 Darrick J. Wong
2026-10-08 5:55 ` [PATCH 01/12] xfs: check for termination during rmap btree walk Darrick J. Wong
2026-10-08 11:52 ` Christoph Hellwig
2026-10-08 5:55 ` [PATCH 02/12] xfs: don't subtract excess usage twice when computing agf_btreeblks Darrick J. Wong
2026-10-08 11:54 ` Christoph Hellwig
2026-10-08 15:44 ` Darrick J. Wong
2026-10-08 5:55 ` [PATCH 03/12] xfs: abort directory tree repair whenever dl->aborted is set Darrick J. Wong
2026-10-08 11:54 ` Christoph Hellwig
2026-10-08 5:55 ` [PATCH 04/12] xfs: reattach dquots after changing inode ids Darrick J. Wong
2026-10-08 11:57 ` Christoph Hellwig
2026-10-08 17:20 ` Darrick J. Wong [this message]
2026-10-08 5:56 ` [PATCH 05/12] xfs: never reset the default quota timer Darrick J. Wong
2026-10-08 11:57 ` Christoph Hellwig
2026-10-08 5:56 ` [PATCH 06/12] xfs: fix correction of unwritten extents in quota file data fork Darrick J. Wong
2026-10-08 12:00 ` Christoph Hellwig
2026-10-08 15:59 ` Darrick J. Wong
2026-10-08 5:56 ` [PATCH 07/12] xfs: always report inode repair setup failures Darrick J. Wong
2026-10-08 12:00 ` Christoph Hellwig
2026-10-08 5:56 ` [PATCH 08/12] xfs: range-check bc_levels array access in scrub tracepoints Darrick J. Wong
2026-10-08 12:01 ` Christoph Hellwig
2026-10-08 5:57 ` [PATCH 09/12] xfs: reject absurdly large xattr value lengths in xchk_xattr_actor Darrick J. Wong
2026-10-08 12:01 ` Christoph Hellwig
2026-10-08 5:57 ` [PATCH 10/12] xfs: check for buffer overruns when examining local/remote xattr entries Darrick J. Wong
2026-10-08 12:03 ` Christoph Hellwig
2026-10-08 16:17 ` Darrick J. Wong
2026-10-08 5:57 ` [PATCH 11/12] xfs: clarify various parts of the bitmap API Darrick J. Wong
2026-10-08 12:04 ` Christoph Hellwig
2026-10-08 5:57 ` [PATCH 12/12] xfs: complain loudly when dirtree checker finds broken links Darrick J. Wong
2026-10-08 12:04 ` Christoph Hellwig
2026-10-08 17:36 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008172004.GT2705364@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox