From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 06/12] xfs: fix correction of unwritten extents in quota file data fork
Date: Thu, 8 Oct 2026 05:00:05 -0700 [thread overview]
Message-ID: <aseFxRJQwFyvJM2v@infradead.org> (raw)
In-Reply-To: <179141521385.2728617.15371099582568233395.stgit@frogsfrogsfrogs>
On Wed, Oct 07, 2026 at 10:56:24PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> LOLLM noticed a couple of problems with the code that fixes unwritten
> mappings in the quota file's data fork: first, we should zero the ondisk
> contents as part of converting them to "unwritten" just in case we crash
> shortly after the conversion. Second, and more importantly, it noticed
> that we fail to resynchronize the iext tree cursor after modifying the
> iext tree. If the tree shape changes, we could be in a world of hurt.
> Third, we should force a quotacheck if we reset an ondisk dquot. Fix
> all issues.
I don't think the existing code here that mixes raw cursor based
iext access and xfs_bmapi_write is safe, and that is probably also
the root cause of the sashiko complaints. So we'll probably need
to drop out of the loop, finish and restart from the new offset.
next prev parent reply other threads:[~2026-10-08 12:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 5:55 [PATCHSET] xfs: LLM-inspired bug fixes, part 21 Darrick J. Wong
2026-10-08 5:55 ` [PATCH 01/12] xfs: check for termination during rmap btree walk Darrick J. Wong
2026-10-08 11:52 ` Christoph Hellwig
2026-10-08 5:55 ` [PATCH 02/12] xfs: don't subtract excess usage twice when computing agf_btreeblks Darrick J. Wong
2026-10-08 11:54 ` Christoph Hellwig
2026-10-08 15:44 ` Darrick J. Wong
2026-10-08 5:55 ` [PATCH 03/12] xfs: abort directory tree repair whenever dl->aborted is set Darrick J. Wong
2026-10-08 11:54 ` Christoph Hellwig
2026-10-08 5:55 ` [PATCH 04/12] xfs: reattach dquots after changing inode ids Darrick J. Wong
2026-10-08 11:57 ` Christoph Hellwig
2026-10-08 17:20 ` Darrick J. Wong
2026-10-08 5:56 ` [PATCH 05/12] xfs: never reset the default quota timer Darrick J. Wong
2026-10-08 11:57 ` Christoph Hellwig
2026-10-08 5:56 ` [PATCH 06/12] xfs: fix correction of unwritten extents in quota file data fork Darrick J. Wong
2026-10-08 12:00 ` Christoph Hellwig [this message]
2026-10-08 15:59 ` Darrick J. Wong
2026-10-08 5:56 ` [PATCH 07/12] xfs: always report inode repair setup failures Darrick J. Wong
2026-10-08 12:00 ` Christoph Hellwig
2026-10-08 5:56 ` [PATCH 08/12] xfs: range-check bc_levels array access in scrub tracepoints Darrick J. Wong
2026-10-08 12:01 ` Christoph Hellwig
2026-10-08 5:57 ` [PATCH 09/12] xfs: reject absurdly large xattr value lengths in xchk_xattr_actor Darrick J. Wong
2026-10-08 12:01 ` Christoph Hellwig
2026-10-08 5:57 ` [PATCH 10/12] xfs: check for buffer overruns when examining local/remote xattr entries Darrick J. Wong
2026-10-08 12:03 ` Christoph Hellwig
2026-10-08 16:17 ` Darrick J. Wong
2026-10-08 5:57 ` [PATCH 11/12] xfs: clarify various parts of the bitmap API Darrick J. Wong
2026-10-08 12:04 ` Christoph Hellwig
2026-10-08 5:57 ` [PATCH 12/12] xfs: complain loudly when dirtree checker finds broken links Darrick J. Wong
2026-10-08 12:04 ` Christoph Hellwig
2026-10-08 17:36 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aseFxRJQwFyvJM2v@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox