Re: [PATCH v2 2/2] xfs: add support for FALLOC_FL_WRITE_ZEROES

[Pankaj <pankaj.raghav@linux.dev>]

>> @@ -1470,7 +1521,7 @@ xfs_falloc_allocate_range(
>>  		(FALLOC_FL_ALLOCATE_RANGE | FALLOC_FL_KEEP_SIZE |	\
>>  		 FALLOC_FL_PUNCH_HOLE |	FALLOC_FL_COLLAPSE_RANGE |	\
>>  		 FALLOC_FL_ZERO_RANGE |	FALLOC_FL_INSERT_RANGE |	\
>> -		 FALLOC_FL_UNSHARE_RANGE)
>> +		 FALLOC_FL_UNSHARE_RANGE | FALLOC_FL_WRITE_ZEROES)
>> 
>>  STATIC long
>>  __xfs_file_fallocate(
>> @@ -1522,6 +1573,9 @@ __xfs_file_fallocate(
>>  	case FALLOC_FL_ALLOCATE_RANGE:
>>  		error = xfs_falloc_allocate_range(file, mode, offset, len);
>>  		break;
>> +	case FALLOC_FL_WRITE_ZEROES:
>> +		error = xfs_falloc_write_zeroes(file, mode, offset, len, ac);
>> +		break;
>>  	default:
>>  		error = -EOPNOTSUPP;
>>  		break;
>
>I have debug option to skip the check of LBPRZ/DLFEAT on the underlying
>device for testing on regular devices.
>

Ah, this is a good idea. I can fold these changes in the next version.

FWIW,  there was a bug in QEMU which disabled this feature for emulated NVMe devices which has been fixed now [1]


[1]https://lore.kernel.org/qemu-devel/aa_w-cz2nKsCdkMi@AALNPWKJENSEN.aal.scsc.local/

--
Pankaj Raghav