Re: [PATCH v2 0/2] add FALLOC_FL_WRITE_ZEROES support to xfs

[Lukas Herbolt <lukas@herbolt.com>]

On 2026-04-13 15:32, Pankaj Raghav wrote:
> The benefits of FALLOC_FL_WRITE_ZEROES was already discussed as a part
> of Zhang Yi's initial patches[1]. Postgres developer Andres also
> mentioned they would like to use this feature in Postgres [2].
> 
> This series has the changes proposed by Dave [3].
> 
> I tested the changes with fsstress and fsx based on the xfstests patch 
> I
> sent recently to test this flag[4]. generic/363 helped me debug the
> crash I noticed when I did the initial implementation[3].
> 
> Note: The previous version of Lukas's patches got mixed with version
> numbers. The first patch is v1 while the second patch is v12. I am
> sending it as v2 to make it uniform.
> 
> @Lukas: I didn't notice any activity from you regarding this series
> since last month, so I decided to send it after spending some time on
> Dave's feedback. I hope it is ok with you.
> 
> Changes since v1 [5.1 5.2]:
> - Added a new function xfs_bmap_alloc_or_convert_range() based on 
> Dave's
>   feedback.
> - Changed the xfs_falloc_write_zeroes to use
>   xfs_bmap_alloc_or_convert_range() instead of doing prealloc and
>   convert approach.
> 
> [1] 
> https://lore.kernel.org/linux-fsdevel/20250619111806.3546162-1-yi.zhang@huaweicloud.com/
> [2] 
> https://lore.kernel.org/linux-fsdevel/20260217055103.GA6174@lst.de/T/#m7935b9bab32bb5ff372507f84803b8753ad1c814
> [3] 
> https://lore.kernel.org/linux-xfs/6i2jvzn3lyugjlbgmjzpped3gogzyqv5mpe2uqaifz4vjpaega@pomzoq7ley77/
> [4] 
> https://lore.kernel.org/linux-xfs/20260312195308.738189-1-p.raghav@samsung.com/
> [5.1] 
> https://lore.kernel.org/linux-xfs/20260309180708.427553-2-lukas@herbolt.com/
> [5.2] https://lore.kernel.org/linux-xfs/abC1LvRElctaHPe5@dread/
> 
> Pankaj Raghav (2):
>   xfs: add xfs_bmap_alloc_or_convert_range function
>   xfs: add support for FALLOC_FL_WRITE_ZEROES
> 
>  fs/xfs/xfs_bmap_util.c | 165 +++++++++++++++++++++++++++++++++++++++++
>  fs/xfs/xfs_bmap_util.h |   3 +
>  fs/xfs/xfs_file.c      |  56 +++++++++++++-
>  fs/xfs/xfs_iomap.c     | 113 +---------------------------
>  fs/xfs/xfs_iomap.h     |   1 +
>  5 files changed, 227 insertions(+), 111 deletions(-)
> 
> 
> base-commit: e0dc9e0f8da83cb70e2a7e9a10fd3541c2bd9a06

> @Lukas: I didn't notice any activity from you regarding this series
> since last month, so I decided to send it after spending some time on
> Dave's feedback. I hope it is ok with you.

No worries. I have actually very similar patch ready but run into some 
issue
with fsx that i wanted to check first.
-- 
-lhe