From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2] libxfs: remove duplicate rtalloc declarations in libxfs.h
Date: Tue, 9 Jul 2024 19:48:27 +1000 [thread overview]
Message-ID: <Zo0Ha9nSs7UrKhSz@dread.disaster.area> (raw)
In-Reply-To: <20240709073444.3023076-1-hch@lst.de>
On Tue, Jul 09, 2024 at 09:34:31AM +0200, Christoph Hellwig wrote:
> These already come from xfs_rtbitmap.h.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>
> Changes since v1:
> - now without spurious man page removal
>
> include/libxfs.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/libxfs.h b/include/libxfs.h
> index fb8efb696..40e41ea77 100644
> --- a/include/libxfs.h
> +++ b/include/libxfs.h
> @@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all(
> irec->br_state = XFS_EXT_NORM;
> }
>
> -/* XXX: this is clearly a bug - a shared header needs to export this */
> -/* xfs_rtalloc.c */
> -int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t);
> -bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno);
> -
> #include "xfs_attr.h"
> #include "topology.h"
Looks good now.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2024-07-09 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-09 7:34 [PATCH v2] libxfs: remove duplicate rtalloc declarations in libxfs.h Christoph Hellwig
2024-07-09 9:48 ` Dave Chinner [this message]
2024-07-09 21:57 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zo0Ha9nSs7UrKhSz@dread.disaster.area \
--to=david@fromorbit.com \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox