* [PATCH v2] libxfs: remove duplicate rtalloc declarations in libxfs.h
@ 2024-07-09 7:34 Christoph Hellwig
2024-07-09 9:48 ` Dave Chinner
2024-07-09 21:57 ` Darrick J. Wong
0 siblings, 2 replies; 3+ messages in thread
From: Christoph Hellwig @ 2024-07-09 7:34 UTC (permalink / raw)
To: cem; +Cc: linux-xfs
These already come from xfs_rtbitmap.h.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
Changes since v1:
- now without spurious man page removal
include/libxfs.h | 5 -----
1 file changed, 5 deletions(-)
diff --git a/include/libxfs.h b/include/libxfs.h
index fb8efb696..40e41ea77 100644
--- a/include/libxfs.h
+++ b/include/libxfs.h
@@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all(
irec->br_state = XFS_EXT_NORM;
}
-/* XXX: this is clearly a bug - a shared header needs to export this */
-/* xfs_rtalloc.c */
-int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t);
-bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno);
-
#include "xfs_attr.h"
#include "topology.h"
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] libxfs: remove duplicate rtalloc declarations in libxfs.h
2024-07-09 7:34 [PATCH v2] libxfs: remove duplicate rtalloc declarations in libxfs.h Christoph Hellwig
@ 2024-07-09 9:48 ` Dave Chinner
2024-07-09 21:57 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Dave Chinner @ 2024-07-09 9:48 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: cem, linux-xfs
On Tue, Jul 09, 2024 at 09:34:31AM +0200, Christoph Hellwig wrote:
> These already come from xfs_rtbitmap.h.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>
> Changes since v1:
> - now without spurious man page removal
>
> include/libxfs.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/libxfs.h b/include/libxfs.h
> index fb8efb696..40e41ea77 100644
> --- a/include/libxfs.h
> +++ b/include/libxfs.h
> @@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all(
> irec->br_state = XFS_EXT_NORM;
> }
>
> -/* XXX: this is clearly a bug - a shared header needs to export this */
> -/* xfs_rtalloc.c */
> -int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t);
> -bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno);
> -
> #include "xfs_attr.h"
> #include "topology.h"
Looks good now.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] libxfs: remove duplicate rtalloc declarations in libxfs.h
2024-07-09 7:34 [PATCH v2] libxfs: remove duplicate rtalloc declarations in libxfs.h Christoph Hellwig
2024-07-09 9:48 ` Dave Chinner
@ 2024-07-09 21:57 ` Darrick J. Wong
1 sibling, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2024-07-09 21:57 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: cem, linux-xfs
On Tue, Jul 09, 2024 at 09:34:31AM +0200, Christoph Hellwig wrote:
> These already come from xfs_rtbitmap.h.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good now,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
>
> Changes since v1:
> - now without spurious man page removal
>
> include/libxfs.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/libxfs.h b/include/libxfs.h
> index fb8efb696..40e41ea77 100644
> --- a/include/libxfs.h
> +++ b/include/libxfs.h
> @@ -220,11 +220,6 @@ libxfs_bmbt_disk_get_all(
> irec->br_state = XFS_EXT_NORM;
> }
>
> -/* XXX: this is clearly a bug - a shared header needs to export this */
> -/* xfs_rtalloc.c */
> -int libxfs_rtfree_extent(struct xfs_trans *, xfs_rtblock_t, xfs_extlen_t);
> -bool libxfs_verify_rtbno(struct xfs_mount *mp, xfs_rtblock_t rtbno);
> -
> #include "xfs_attr.h"
> #include "topology.h"
>
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-09 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-09 7:34 [PATCH v2] libxfs: remove duplicate rtalloc declarations in libxfs.h Christoph Hellwig
2024-07-09 9:48 ` Dave Chinner
2024-07-09 21:57 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox