From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: allow SECURE namespace xattrs to use reserved pool
Date: Mon, 22 Jul 2024 07:41:47 -0700 [thread overview]
Message-ID: <Zp5vq86RtodlF-d1@infradead.org> (raw)
In-Reply-To: <fa801180-0229-4ea7-b8eb-eb162935d348@redhat.com>
On Fri, Jul 19, 2024 at 05:48:53PM -0500, Eric Sandeen wrote:
> xfs_attr_sethash(args);
>
> - return xfs_attr_set(args, op, args->attr_filter & XFS_ATTR_ROOT);
> + rsvd = args->attr_filter & (XFS_ATTR_ROOT | XFS_ATTR_SECURE);
> + return xfs_attr_set(args, op, rsvd);
This looks fine, although I'd probably do without the extra local
variable. More importantly though, please write a comment documenting
why we are dipping into the reserved pool here. We should have had that
since the beginning, but this is a better time than never.
next prev parent reply other threads:[~2024-07-22 14:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 22:48 [PATCH] xfs: allow SECURE namespace xattrs to use reserved pool Eric Sandeen
2024-07-22 14:41 ` Christoph Hellwig [this message]
2024-07-22 15:05 ` Eric Sandeen
2024-07-22 15:11 ` Christoph Hellwig
2024-07-22 16:43 ` [External] : " mark.tinguely
2024-07-22 22:45 ` Dave Chinner
2024-07-22 19:25 ` [PATCH V2] xfs: allow SECURE namespace xattrs to use reserved block pool Eric Sandeen
2024-07-22 23:05 ` Dave Chinner
2024-07-23 14:59 ` [PATCH V3] " Eric Sandeen
2024-07-23 16:52 ` Darrick J. Wong
2024-07-23 16:56 ` Christoph Hellwig
2024-07-23 17:26 ` [PATCH V4] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp5vq86RtodlF-d1@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox