From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH V3] xfs: allow SECURE namespace xattrs to use reserved block pool
Date: Tue, 23 Jul 2024 09:56:10 -0700 [thread overview]
Message-ID: <Zp_gqoQ7y7SPUXhz@infradead.org> (raw)
In-Reply-To: <7ecf75c9-4727-4cde-ba5a-0736ea4128e9@redhat.com>
> + /*
> + * Some xattrs must be resistent to allocation failure at
> + * ENOSPC. e.g. creating an inode with ACLs or security
> + * attributes requires the allocation of the xattr holding
> + * that information to succeed. Hence we allow xattrs in the
If you repin this anyway because of the spelling nit maybe use up all
80 characters to make the comment a bit easier to read.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2024-07-23 16:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 22:48 [PATCH] xfs: allow SECURE namespace xattrs to use reserved pool Eric Sandeen
2024-07-22 14:41 ` Christoph Hellwig
2024-07-22 15:05 ` Eric Sandeen
2024-07-22 15:11 ` Christoph Hellwig
2024-07-22 16:43 ` [External] : " mark.tinguely
2024-07-22 22:45 ` Dave Chinner
2024-07-22 19:25 ` [PATCH V2] xfs: allow SECURE namespace xattrs to use reserved block pool Eric Sandeen
2024-07-22 23:05 ` Dave Chinner
2024-07-23 14:59 ` [PATCH V3] " Eric Sandeen
2024-07-23 16:52 ` Darrick J. Wong
2024-07-23 16:56 ` Christoph Hellwig [this message]
2024-07-23 17:26 ` [PATCH V4] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zp_gqoQ7y7SPUXhz@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox