From: Christoph Hellwig <hch@infradead.org>
To: fdmanana@kernel.org
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Filipe Manana <fdmanana@suse.com>,
linux-xfs@vger.kernel.org, johannes.thumshirn@wdc.com,
naohiro.aota@wdc.com
Subject: Re: [PATCH v2] generic: test overwriting file with mmap on a full filesystem
Date: Mon, 21 Jul 2025 23:55:59 -0700 [thread overview]
Message-ID: <aH81_3bxZZrG4R2b@infradead.org> (raw)
In-Reply-To: <681c9dcaca0bf16a694d8f56449618001cf20df6.1752166696.git.fdmanana@suse.com>
I just noticed this test failing on zoned xfs in current for-next.
That's because for out of place overwrite file systems writing at
ENOSPC will obviously fail, and I think the test acknowledges that
by forcing nocow for btrfs.
But that leaves "real" out of place write file systems affected, which
should also include zone btrfs, but the test actually fails there
in mkfs already due to some reason.
Can you please rework the patch to see that setting the nocow flag
works first and only try with that or something like that?
next parent reply other threads:[~2025-07-22 6:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f28ef5098ed18d53df6f94faded1b352bb833527.1752049536.git.fdmanana@suse.com>
[not found] ` <681c9dcaca0bf16a694d8f56449618001cf20df6.1752166696.git.fdmanana@suse.com>
2025-07-22 6:55 ` Christoph Hellwig [this message]
2025-07-22 7:50 ` [PATCH v2] generic: test overwriting file with mmap on a full filesystem Johannes Thumshirn
2025-07-22 8:16 ` hch
2025-07-22 10:27 ` Filipe Manana
2025-07-23 5:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aH81_3bxZZrG4R2b@infradead.org \
--to=hch@infradead.org \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox