From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: "hch@infradead.org" <hch@infradead.org>,
"fdmanana@kernel.org" <fdmanana@kernel.org>
Cc: "fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Filipe Manana <fdmanana@suse.com>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
Naohiro Aota <Naohiro.Aota@wdc.com>
Subject: Re: [PATCH v2] generic: test overwriting file with mmap on a full filesystem
Date: Tue, 22 Jul 2025 07:50:48 +0000 [thread overview]
Message-ID: <ee8d5d39-7898-4e45-9f4c-359c2c7a64fd@wdc.com> (raw)
In-Reply-To: <aH81_3bxZZrG4R2b@infradead.org>
On 22.07.25 08:56, Christoph Hellwig wrote:
> I just noticed this test failing on zoned xfs in current for-next.
>
> That's because for out of place overwrite file systems writing at
> ENOSPC will obviously fail, and I think the test acknowledges that
> by forcing nocow for btrfs.
>
> But that leaves "real" out of place write file systems affected, which
> should also include zone btrfs, but the test actually fails there
> in mkfs already due to some reason.
It probably fails the _try_scratch_mkfs_sized() call because that goes
into _check_minimal_fs_size() and that should _notrun if $fssize <
$MIN_FSSIZE.
> Can you please rework the patch to see that setting the nocow flag
> works first and only try with that or something like that?
>
>
next prev parent reply other threads:[~2025-07-22 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f28ef5098ed18d53df6f94faded1b352bb833527.1752049536.git.fdmanana@suse.com>
[not found] ` <681c9dcaca0bf16a694d8f56449618001cf20df6.1752166696.git.fdmanana@suse.com>
2025-07-22 6:55 ` [PATCH v2] generic: test overwriting file with mmap on a full filesystem Christoph Hellwig
2025-07-22 7:50 ` Johannes Thumshirn [this message]
2025-07-22 8:16 ` hch
2025-07-22 10:27 ` Filipe Manana
2025-07-23 5:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee8d5d39-7898-4e45-9f4c-359c2c7a64fd@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox