[PATCH v3] xfs: Fix the return value of xfs_rtcopy_summary()

[PATCH v3] xfs: Fix the return value of xfs_rtcopy_summary()

[Nirjhar Roy (IBM)]

xfs_rtcopy_summary() should return the appropriate error code
instead of always returning 0. The caller of this function which is
xfs_growfs_rt_bmblock() is already handling the error.

Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Cc: <stable@vger.kernel.org> # v6.7
---
 fs/xfs/xfs_rtalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
index 6907e871fa15..bc88b965e909 100644
--- a/fs/xfs/xfs_rtalloc.c
+++ b/fs/xfs/xfs_rtalloc.c
@@ -126,7 +126,7 @@ xfs_rtcopy_summary(
 	error = 0;
 out:
 	xfs_rtbuf_cache_relse(oargs);
-	return 0;
+	return error;
 }
 /*
  * Mark an extent specified by start and len allocated.
-- 
2.43.5

Re: [PATCH v3] xfs: Fix the return value of xfs_rtcopy_summary()

[Christoph Hellwig]

On Wed, Dec 17, 2025 at 10:04:32PM +0530, Nirjhar Roy (IBM) wrote:
> xfs_rtcopy_summary() should return the appropriate error code
> instead of always returning 0. The caller of this function which is
> xfs_growfs_rt_bmblock() is already handling the error.
> 
> Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> Cc: <stable@vger.kernel.org> # v6.7

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH v3] xfs: Fix the return value of xfs_rtcopy_summary()

[Nirjhar Roy (IBM)]

On 12/18/25 10:44, Christoph Hellwig wrote:
> On Wed, Dec 17, 2025 at 10:04:32PM +0530, Nirjhar Roy (IBM) wrote:
>> xfs_rtcopy_summary() should return the appropriate error code
>> instead of always returning 0. The caller of this function which is
>> xfs_growfs_rt_bmblock() is already handling the error.
>>
>> Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
>> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
>> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
>> Cc: <stable@vger.kernel.org> # v6.7
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Hi Carlos,

Are this and [1] getting picked up?

[1] https://lore.kernel.org/all/aTFWJrOYXEeFX1kY@infradead.org/

--NR

>
-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore

Re: [PATCH v3] xfs: Fix the return value of xfs_rtcopy_summary()

[Carlos Maiolino]

On Mon, Jan 12, 2026 at 11:43:53AM +0530, Nirjhar Roy (IBM) wrote:
> 
> On 12/18/25 10:44, Christoph Hellwig wrote:
> > On Wed, Dec 17, 2025 at 10:04:32PM +0530, Nirjhar Roy (IBM) wrote:
> > > xfs_rtcopy_summary() should return the appropriate error code
> > > instead of always returning 0. The caller of this function which is
> > > xfs_growfs_rt_bmblock() is already handling the error.
> > > 
> > > Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
> > > Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> > > Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> > > Cc: <stable@vger.kernel.org> # v6.7
> > Looks good:
> > 
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> 
> Hi Carlos,
> 
> Are this and [1] getting picked up?
> 
> [1] https://lore.kernel.org/all/aTFWJrOYXEeFX1kY@infradead.org/

Hello.

I can't find a new version on my mbox. Christoph asked you to fix the
commit log on the patch you mentioned.

If you sent a new version and I missed it, please let me know.

Carlos
 
> 
> --NR
> 
> > 
> -- 
> Nirjhar Roy
> Linux Kernel Developer
> IBM, Bangalore
> 
> 

Re: [PATCH v3] xfs: Fix the return value of xfs_rtcopy_summary()

[Nirjhar Roy (IBM)]

On 1/12/26 13:40, Carlos Maiolino wrote:
> On Mon, Jan 12, 2026 at 11:43:53AM +0530, Nirjhar Roy (IBM) wrote:
>> On 12/18/25 10:44, Christoph Hellwig wrote:
>>> On Wed, Dec 17, 2025 at 10:04:32PM +0530, Nirjhar Roy (IBM) wrote:
>>>> xfs_rtcopy_summary() should return the appropriate error code
>>>> instead of always returning 0. The caller of this function which is
>>>> xfs_growfs_rt_bmblock() is already handling the error.
>>>>
>>>> Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
>>>> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
>>>> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
>>>> Cc: <stable@vger.kernel.org> # v6.7
>>> Looks good:
>>>
>>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Hi Carlos,
>>
>> Are this and [1] getting picked up?
>>
>> [1] https://lore.kernel.org/all/aTFWJrOYXEeFX1kY@infradead.org/
> Hello.
>
> I can't find a new version on my mbox. Christoph asked you to fix the
> commit log on the patch you mentioned.
>
> If you sent a new version and I missed it, please let me know.

Sorry, I have re-sent it now [1]. Anything about [2]?

[1] 
https://lore.kernel.org/all/9b2e055a1e714dacf37b4479e2aab589f3cec7f6.1768205975.git.nirjhar.roy.lists@gmail.com/

[2] https://lore.kernel.org/all/aUONoL924Sw_su9J@infradead.org/

--NR

>
> Carlos
>   
>> --NR
>>
>> -- 
>> Nirjhar Roy
>> Linux Kernel Developer
>> IBM, Bangalore
>>
>>
-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore

Re: [PATCH v3] xfs: Fix the return value of xfs_rtcopy_summary()

[Carlos Maiolino]

On Mon, Jan 12, 2026 at 02:10:01PM +0530, Nirjhar Roy (IBM) wrote:
> 
> On 1/12/26 13:40, Carlos Maiolino wrote:
> > On Mon, Jan 12, 2026 at 11:43:53AM +0530, Nirjhar Roy (IBM) wrote:
> > > On 12/18/25 10:44, Christoph Hellwig wrote:
> > > > On Wed, Dec 17, 2025 at 10:04:32PM +0530, Nirjhar Roy (IBM) wrote:
> > > > > xfs_rtcopy_summary() should return the appropriate error code
> > > > > instead of always returning 0. The caller of this function which is
> > > > > xfs_growfs_rt_bmblock() is already handling the error.
> > > > > 
> > > > > Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
> > > > > Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> > > > > Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> > > > > Cc: <stable@vger.kernel.org> # v6.7
> > > > Looks good:
> > > > 
> > > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > > Hi Carlos,
> > > 
> > > Are this and [1] getting picked up?
> > > 
> > > [1] https://lore.kernel.org/all/aTFWJrOYXEeFX1kY@infradead.org/
> > Hello.
> > 
> > I can't find a new version on my mbox. Christoph asked you to fix the
> > commit log on the patch you mentioned.
> > 
> > If you sent a new version and I missed it, please let me know.
> 
> Sorry, I have re-sent it now [1]. Anything about [2]?

I think think it slipped through the cracks, could you please re-send
it? I'll pick both this week.

Carlos

> 
> [1] https://lore.kernel.org/all/9b2e055a1e714dacf37b4479e2aab589f3cec7f6.1768205975.git.nirjhar.roy.lists@gmail.com/
> 
> [2] https://lore.kernel.org/all/aUONoL924Sw_su9J@infradead.org/
> 
> --NR
> 
> > 
> > Carlos
> > > --NR
> > > 
> > > -- 
> > > Nirjhar Roy
> > > Linux Kernel Developer
> > > IBM, Bangalore
> > > 
> > > 
> -- 
> Nirjhar Roy
> Linux Kernel Developer
> IBM, Bangalore
> 
> 

Re: [PATCH v3] xfs: Fix the return value of xfs_rtcopy_summary()

[Nirjhar Roy (IBM)]

On 1/12/26 15:26, Carlos Maiolino wrote:
> On Mon, Jan 12, 2026 at 02:10:01PM +0530, Nirjhar Roy (IBM) wrote:
>> On 1/12/26 13:40, Carlos Maiolino wrote:
>>> On Mon, Jan 12, 2026 at 11:43:53AM +0530, Nirjhar Roy (IBM) wrote:
>>>> On 12/18/25 10:44, Christoph Hellwig wrote:
>>>>> On Wed, Dec 17, 2025 at 10:04:32PM +0530, Nirjhar Roy (IBM) wrote:
>>>>>> xfs_rtcopy_summary() should return the appropriate error code
>>>>>> instead of always returning 0. The caller of this function which is
>>>>>> xfs_growfs_rt_bmblock() is already handling the error.
>>>>>>
>>>>>> Fixes: e94b53ff699c ("xfs: cache last bitmap block in realtime allocator")
>>>>>> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
>>>>>> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
>>>>>> Cc: <stable@vger.kernel.org> # v6.7
>>>>> Looks good:
>>>>>
>>>>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>>> Hi Carlos,
>>>>
>>>> Are this and [1] getting picked up?
>>>>
>>>> [1] https://lore.kernel.org/all/aTFWJrOYXEeFX1kY@infradead.org/
>>> Hello.
>>>
>>> I can't find a new version on my mbox. Christoph asked you to fix the
>>> commit log on the patch you mentioned.
>>>
>>> If you sent a new version and I missed it, please let me know.
>> Sorry, I have re-sent it now [1]. Anything about [2]?
> I think think it slipped through the cracks, could you please re-send
> it? I'll pick both this week.

Sure, no problem. I have re-sent both [1] and [2].

[1] 
https://lore.kernel.org/all/587bff140dc86fec629cd41db0af8c00fb9623d0.1768212233.git.nirjhar.roy.lists@gmail.com/

[2] 
https://lore.kernel.org/all/9b2e055a1e714dacf37b4479e2aab589f3cec7f6.1768205975.git.nirjhar.roy.lists@gmail.com/

--NR

>
> Carlos
>
>> [1] https://lore.kernel.org/all/9b2e055a1e714dacf37b4479e2aab589f3cec7f6.1768205975.git.nirjhar.roy.lists@gmail.com/
>>
>> [2] https://lore.kernel.org/all/aUONoL924Sw_su9J@infradead.org/
>>
>> --NR
>>
>>> Carlos
>>>> --NR
>>>>
>>>> -- 
>>>> Nirjhar Roy
>>>> Linux Kernel Developer
>>>> IBM, Bangalore
>>>>
>>>>
>> -- 
>> Nirjhar Roy
>> Linux Kernel Developer
>> IBM, Bangalore
>>
>>
-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore