From: Carlos Maiolino <cem@kernel.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: Should we hook up sashiko.dev?
Date: Wed, 15 Apr 2026 20:40:53 +0200 [thread overview]
Message-ID: <ad_axvVel2tpEcLq@nidhogg.toxiclabs.cc> (raw)
In-Reply-To: <87c6dc3d-ed23-4ae9-8309-0782ffd9b191@sandeen.net>
On Wed, Apr 15, 2026 at 11:49:50AM -0500, Eric Sandeen wrote:
> Hi all -
>
> "Sashiko is an agentic Linux kernel code review system. It monitors public mailing lists to thoroughly evaluate proposed Linux kernel changes. The system acts like a team of specialized reviewers covering domains from high-level architecture verification and security audits to low-level resource management and concurrency analysis."
>
> This is something built by Chris Mason and others, with Google providing the LLM and tokens.
>
> The website sashiko.dev shows these review results for mailing lists it is subscribed to, so you can browse around and see how it works. I've heard reasonably positive feedback from some who've used it already.
>
> We could send a PR to request adding linux-xfs, and I think we should try it.
>
> However, if you look at the config, for example for linux-ext4:
> https://github.com/sashiko-dev/sashiko/commit/d921c59
>
> there are options to:
>
> 1) reply back to the patch other (or not), and
> 2) automatically cc: one more more people on every review if desired
>
> so before single-handedly making this decision for every future patch author
> and/or possible cc: individuals, what do we think?
>
> (One can drive Sashiko from the command line, too, with or without the list
> subscription mentioned above, see the github repo for details.)
>
> Oh, and I guess we could add xfs-specific review prompts, too, see
> https://github.com/masoncl/review-prompts/blob/main/kernel/subsystem/btrfs.md
> for example. EXT4, OTOH, does not have this. (and the btrfs prompt looks quite
> limited right now.) Maybe we could distill the xfs documentation into prompts...
> but I'm getting ahead of myself now.
>
I think it's a fair idea. I've been talking with Mason about it and it's
on my todo list pile to look into it for a while, but I didn't come to
that yet. I have an initial concern on who will be reviewing its output,
but I didn't really put any thoughts about it yet.
> Thanks,
> -Eric
>
next prev parent reply other threads:[~2026-04-15 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 16:49 Should we hook up sashiko.dev? Eric Sandeen
2026-04-15 18:40 ` Carlos Maiolino [this message]
2026-04-15 18:45 ` Eric Sandeen
2026-04-20 8:54 ` Andrey Albershteyn
2026-04-21 23:47 ` Eric Sandeen
2026-04-22 11:35 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad_axvVel2tpEcLq@nidhogg.toxiclabs.cc \
--to=cem@kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox